Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark themes unusable #17

Open
Argenteus opened this issue Nov 7, 2012 · 13 comments
Open

Dark themes unusable #17

Argenteus opened this issue Nov 7, 2012 · 13 comments

Comments

@Argenteus
Copy link

Noticed the dark themes included with the pack include a white highlight across the current line. This makes them unusable, because the text is also often white.

@codebrainz
Copy link
Owner

What version of the themes are you using and what version of Geany? It's not the first time I've heard this issue but I cannot reproduce and the only thing I can figure is a mixup of versions (themes version not same as Geany version and/or filetypes* files from older Geany versions from before upgrading).

If you can start Geany from the terminal with geany -v and paste your debugging messages here it might be helpful, since it shows Geany version, GTK/GLIB version and also should report any errors during parsing of themes.

@Argenteus
Copy link
Author

According to the status window at least, I'm using geany 0.21 and I'm almost 100% certain I got the 0.21 version (I got it from the link at the Geany wiki). I've managed to circumvent it by using the light version of the color theme I'm using (Tango Light/Dark) and setting it to invert colors, but it seems like something that should be fixed.

@codebrainz
Copy link
Owner

Can you paste the stuff from Help->Debug messages for an instance of Geany that has an affected scheme applied? It should have some message like "error: bad such and such current_line" while it is parsing the scheme, which will help me figure out where the problem is.

@codebrainz
Copy link
Owner

Ping

@Argenteus
Copy link
Author

Oh, I'm sorry, I completely forgot once geany was usable again. I'll get you those messages.

On a fresh startup with the theme enabled:

@Argenteus
Copy link
Author

Oh, I'm sorry, I completely forgot once geany was usable again. I'll get you those messages.

On a fresh startup with the theme enabled:

21:11:00: Geany INFO : Geany 0.21, en_US.UTF-8
21:11:00: Geany INFO : GTK 2.24.10, GLib 2.33.1
21:11:00: Geany INFO : System data dir: /usr/share/geany
21:11:00: Geany INFO : User config dir: /home/cgriffitt/.config/geany
21:11:00: Geany INFO : Added filetype Scala (52).
21:11:00: Geany INFO : Added filetype Cython (53).
21:11:00: Geany INFO : Added filetype Genie (54).
21:11:01: Geany INFO : unknown : None (UTF-8)
21:11:03: LIBDBUSMENU-GTK CRITICAL : watch_submenu: assertion `GTK_IS_MENU_SHELL(menu)' failed

None after switching to the theme with messages cleared on an existing session.

@codebrainz
Copy link
Owner

Hmm, nothing really unusual there. Not too sure how to proceed unless you can ensure you got the right version of geany-themes and try moving older filetypes out of the way. If you get bored and can try that, it'd be cool. I'll leave the Issue open in case others come along with the issue.

Thanks for following up

@adduc
Copy link

adduc commented Jun 11, 2013

To replicate what @Argenteus experienced:

  • Uncheck "Show markers margin" in Preferences->Editor->Display.
  • Click on a function/section/etc in the 'Symbols' side panel.

When "Show markers margin" is enabled, an arrow is shown in the marker margin to mark where the selected function/section/etc. is. When "Show markers margin" is disabled, the color of the arrow is used to highlight the line in lieu of an arrow.

The colors in question that may need to be modified are located in the named_styles.marker_line attribute.

@ynnk
Copy link

ynnk commented Jun 13, 2013

Hi it seams that color are handled in a strange way in scheme ( look like 1-color )

tango-light.conf :

keyword=#00ffff;;true

i ll get a red keyword
keyword=#0000ff;;true
will print in yellow
keyword=#ff00ff;;true
got it ? you have green

It seems to have the same behavior with version shipped under xubuntu 12.4 repo
( it dont remember version number)
and a fresh install latest release

i updated because i suspect the version in repo was too iold.

$ geany -V
geany 1.23.1 (built on Jun 13 2013 with GTK 2.24.10, GLib 2.32.3)

Debug message shows something critical
#====================================================
00:35:19: Geany INFO : Geany 1.23.1, en_US.UTF-8
00:35:19: Geany INFO : GTK 2.24.10, GLib 2.32.3
00:35:19: Geany INFO : System data dir: /usr/local/share/geany
00:35:19: Geany INFO : User config dir: /home/yan/.config/geany
00:35:19: Geany INFO : System plugin path: /usr/local/lib/geany
00:35:19: Geany INFO : Added filetype Cython (55).
00:35:19: Geany INFO : Added filetype Scala (56).
00:35:19: Geany INFO : Added filetype Genie (57).
00:35:19: Geany INFO : Added filetype Go (58).
00:35:19: Geany INFO : /home/yan/.config/geany/colorschemes/tango-dark.conf : Conf (UTF-8)
00:35:19: Geany INFO : /home/yan/.config/geany/colorschemes/tango-light.conf : Conf (UTF-8)
00:35:19: Geany INFO : /media/wkspace/work/kodex-project/trunk/wwwapps/nvk_app/view_dicosyn.py : Python (UTF-8)
00:35:19: Geany INFO : Loaded /usr/local/share/geany/python.tags (Python), 5964 tag(s).
00:35:19: LIBDBUSMENU-GTK CRITICAL : watch_submenu: assertion `GTK_IS_MENU_SHELL(menu)' failed

hope that helps !
i come from gedit and found geany full of goodies but a little tricky to scheme ...

@codebrainz
Copy link
Owner

I can't reproduce but if someone provides a patch I will commit it.

@ynnk
Copy link

ynnk commented Jun 17, 2013

  • i tried to reinstall from gitub
    geany 1.24 (git >= 79db59d) (built on 2013-06-16 with GTK 2.24.10, GLib 2.32.3)
    but gives same issue
  • i also installed on another machine with same version of geany, GTK and glib
    and works perfectly

don't know where this negative colors effect comes from ...

@codebrainz
Copy link
Owner

@ynnk Did you update to latest colour schemes after updating to newest Geany? It's important there aren't any old filetypes or colorschemes hanging around your system. Likely places: /usr/share/geany/*, /usr/local/share/geany/*, ~/.config/geany/*. You can also run Geany with a new/blank configuration like geany -c /tmp or geany -c /dev/null (last one will cause warning message). Since you mentioned negative colour effect, I don't suppose you have Preferences->Editor->Invert syntax highlighting colours enabled?

@adduc I still can't reproduce, any chance you could try messing around with the colour scheme in question to confirm what (definitively) needs to be changed?

@ALL I don't suppose it's something weird like the selection colour of the GTK+ theme? Could you try to change the GTK+ theme to something else and see, maybe only problem appears on certain theme you guys are using?

@ynnk
Copy link

ynnk commented Jun 20, 2013

Since you mentioned negative colour effect, I don't suppose you have Preferences->Editor->Invert syntax highlighting colours enabled?

Shame, didn't see that option before... Sorry for inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants