Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not an issue #7

Open
crssi opened this issue Dec 20, 2018 · 24 comments
Open

Not an issue #7

crssi opened this issue Dec 20, 2018 · 24 comments

Comments

@crssi
Copy link
Collaborator

crssi commented Dec 20, 2018

THANK YOU for one of the privacy essential extension.

Cheers

@claustromaniac
Copy link
Owner

Glad to be of help!

@atomGit
Copy link

atomGit commented Dec 21, 2018

that lil pink turd looks so cute on mah toolbar!

the v1 update is quite a piece of work ... now i'm gonna have to update my FF guide :(

@claustromaniac
Copy link
Owner

claustromaniac commented Dec 21, 2018

the v1 update is quite a piece of work ... now i'm gonna have to update my FF guide :(

You can thank/blame @crssi for that, since like more than half of the features were his idea. 😁

@Thorin-Oakenpants
Copy link

hey 🐈 .. FYI reddit .. in case you wanted to reply to anything anyone says there

@claustromaniac
Copy link
Owner

claustromaniac commented Jan 3, 2019

Thanks, but nah. If the poster wanted me to reply he would be asking me.

@claustromaniac
Copy link
Owner

I updated the documentation to explain in some more detail (without extending myself too much) why I consider this extension safe. I guess many people won't even bother reading that, but I don't care.

@atomGit
Copy link

atomGit commented Jan 4, 2019

thanks for that claus! however i think i have a new (potentially dumb) question...

if one is using uBO and/or uM to filter all 3rd party requests (except CSS and images in my case), and FPI is enabled, is poop still desirable?

i'm guessing the answer is 'yes' because when i look at uM and poop for this page here on github, where i allow requests for github.com and githubassets.com in uM, i see poop is altering 5 requests

@crssi
Copy link
Collaborator Author

crssi commented Jan 4, 2019

Well, you have answered with:

except CSS

There are also CSS leaks to be seen. Not very often, but still are and I would wild guess that in the future we could see even more leakages over CSS requests.

Otherwise, if you block all 3rd party's in uBO/uM, then you would not need PooP IMHO.
But there are always some 3rd party allowed to make the visited page work. 😉

i'm guessing the answer is 'yes' because when i look at uM and poop for this page here on github, where i allow requests for github.com and githubassets.com in uM, i see poop is altering 5 requests.

Well, in this particular case it doesn't matter, since github already knows that you are at github. 😉
But, even when PooP does alter request, it will (most likely) not lead to breakage.
In case of breakage, you can drop the following to exclusions: *.github.com *.githubassets.com or *.github.com *.github*.com

The only breakages so far found is google and youtube (so google in both cases) and only for XHR (if you enabled also XHR).
In that case drop the following into exclusions:

*.youtube.com *
*.google*.* *

Cheers

@claustromaniac
Copy link
Owner

Well, yeah. The more third-party requests you block, the smaller the surface will be, but as long as there is any surface left you can still potentially benefit from this.

@atomGit
Copy link

atomGit commented Jan 4, 2019

But there are always some 3rd party allowed to make the visited page work

exactly

The only breakages so far ...

dailymotion.com

*.dailymotion.com *.dmcdn.net

tankz!

@crssi
Copy link
Collaborator Author

crssi commented Jan 4, 2019

@atomGit would you be so kind and drop here your PooP configuration and describe what breaks at dailymotion.com, since I just can't find the breakage.

Thank you

@atomGit
Copy link

atomGit commented Jan 4, 2019

i was gonna re-test that before i popped back in, but i can't get vids to play at that ultra-shitty site at all at the moment and no time to troubleshoot

poop:
aggressive, exclude roots ... and that's it, except for the exception i mentioned earlier

@atomGit
Copy link

atomGit commented Jan 4, 2019

oops, sorry - the problem was that i couldn't get videos to play

@crssi
Copy link
Collaborator Author

crssi commented Jan 4, 2019

I just can't reproduce. All videos play here just fine with your settings.

@crssi
Copy link
Collaborator Author

crssi commented Jan 7, 2019

@atomGit do you have any update?

@atomGit
Copy link

atomGit commented Jan 7, 2019

no sir - hadn't done any more testing - you can close this and i'll let you know if i find any issues in the future

@crssi
Copy link
Collaborator Author

crssi commented Jan 7, 2019

I mean, it puzzles me that you had to add *.dailymotion.com *.dmcdn.net in order for video to work at dailymotion, since I cannot reproduce.
Can you try it again without *.dailymotion.com *.dmcdn.net?

@atomGit
Copy link

atomGit commented Jan 7, 2019

finally got that crappy site to play videos - no idea what i did now that i didn't do before

anyway, yes, vids WILL work without *.dailymotion.com *.dmcdn.net

sorry for the trouble

@crssi
Copy link
Collaborator Author

crssi commented Jan 7, 2019

No problem my friend...
OT: I would advise you to set into relaxed mode, additionally (beside font and css) you can check script and XHR. Check Exclude Root domain matches and add exclusions a few posts up.

Cheers

@atomGit
Copy link

atomGit commented Jan 8, 2019

poop wasn't the problem - i had it in aggressive mode when playing the video actually

@crssi
Copy link
Collaborator Author

crssi commented Jan 8, 2019

I know...
OT = off topic 😉
I am just telling you what is the best setting by my standards.

@Thorin-Oakenpants
Copy link

FYI: I am not a fan of poop related jokes, but it's a solid number two

also: https://www.ghacks.net/2019/01/19/privacy-oriented-origin-policy-for-firefox/

@Thorin-Oakenpants
Copy link

🐈 and 💩 https://theoatmeal.com/comics/universe_cat

@claustromaniac
Copy link
Owner

True story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants