-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intro to Storybook templates #431
Comments
Can say for ember, when you do This is what I see as an entry point for ember. What do you have in mind this template is doing? |
Speaking from my experience with the react native project the part which benefits most from having a template is the setup of things like CSS, fonts, icons etc which depending on the framework can be kind of complicated. In the react native example the first section is/was a series of copy and paste for setting up things that aren't directly related to the content of the tutorial such as setting up the font as mentioned. Having this as part of a template is beneficial for reducing setup time and potential for error. The cost is one of maintaining the template so it does not become out of date. This could be as simple as a repo containing the project ready for the tutorial. The other option would be to simplify the tutorial project so it doesn't include additional files or setup etc. |
The way i'm thinking on putting this into effect is basically a 2 step approach. I want to start small and create the repo templates for the various frameworks so that when the reader lands on the get started section for it's framework of choice he/she would only need to run something like: # clone repo
npx degit chromaui/intro-storybook-react-template taskbox
cd taskbox
# install dependencies
npm/yarn install And he or she would be good to go and move onto the next section. I'm well aware of the cost associated with maintenance but it can be mitigated with some tooling already in place, for instance renovatebot. If this "takes off" (pardon the bad pun) it could be made for instance into an ember blueprint that the reader can get by running one single command and he/she would be good to go. Or for example for react native publish the template into npm and allow the reader to run: expo init --template intro-storybook-react-native-template taskbox And once again he/she would be good to go. |
Pull request #435 is fast tracking this. For now the following frameworks are covered:
Ember is suffering of some weird core.js error preventing the build from going through. Something broke and i've raised an issue in the Storybook repo. @gossi if you could take a look i would appreciate it. On that note @dannyhw sometime in the near future i want to coordinate with you and get a status update and see how we could address React Native and Storybook. Sounds good? |
Could you link the issue from storybook so I can find it and can have a look? |
@jonniebigodes yeah im happy to coordinate with you and we can take another look at the react native stuff :). |
Looking at the present state of the Intro to Storybook in its various forms (frameworks), there's a lot of work that the reader needs to do in order to get a minimal viable project setup with Storybook and its framework of choice. As the tutorial is an introductory one the reader should be able to get onboarded with a minimum effort on his part. What i'm thinking here is the following:
With this i would love to hear from @dannyhw as you're "leading the charge" (pardon the bad pun) on the React Native version of Storybook and from @gossi as you're in the forefront of the ember experience with Storybook.
Let me know what you think.
Stay safe
The text was updated successfully, but these errors were encountered: