Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISC] Benchmarking Chonkie Mega-Thread #50

Open
bhavnicksm opened this issue Nov 21, 2024 · 2 comments
Open

[DISC] Benchmarking Chonkie Mega-Thread #50

bhavnicksm opened this issue Nov 21, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@bhavnicksm
Copy link
Collaborator

One place for all Chonkie benchmarking related work quiries and future benchmarking planning.

Will update this...

@bhavnicksm bhavnicksm self-assigned this Nov 21, 2024
@bhavnicksm bhavnicksm pinned this issue Nov 21, 2024
@bhavnicksm bhavnicksm changed the title [DISC] Benchmarking Chonkie mega-thread [DISC] Benchmarking Chonkie Mega-Thread Nov 21, 2024
@bhavnicksm bhavnicksm added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 21, 2024
@sky-2002
Copy link
Contributor

sky-2002 commented Dec 2, 2024

hey @bhavnicksm , Would it be beneficial to incorporate a benchmark suite into the development workflow, similar to unit tests, to proactively identify and address performance bottlenecks during development?
I personally like these kind of tests, so any performance issues could be attributed to the respective code change at the time. I can add this. Let me know your thoughts and if you are aware of any tools or resources related to this.

@bhavnicksm
Copy link
Collaborator Author

hey @bhavnicksm , Would it be beneficial to incorporate a benchmark suite into the development workflow, similar to unit tests, to proactively identify and address performance bottlenecks during development? I personally like these kind of tests, so any performance issues could be attributed to the respective code change at the time. I can add this. Let me know your thoughts and if you are aware of any tools or resources related to this.

Yes! Would love a PR for this, @sky-2002!

But instead of unit tests, it's better if we keep them separate since benchmarking can take a while—we can run them manually since unit tests are run for every push to main at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants