Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply filter on selected spectra #3274

Open
lpatiny opened this issue Oct 18, 2024 · 2 comments
Open

Apply filter on selected spectra #3274

lpatiny opened this issue Oct 18, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request to discuss

Comments

@lpatiny
Copy link
Member

lpatiny commented Oct 18, 2024

@jwist is interested to be able to phase correct many spectra at once.

@hamed-musallam
Copy link
Member

@lpatiny

This is something we need to discuss. The current behavior assumes only one spectrum is selected. If we plan to change this, we need to carefully consider how the processing panel will handle multiple spectra being selected and ensure that the tool remains visible. This primarily affects the UI, but there are also underlying aspects that will need refactoring.

Additionally, I think this change shouldn't be limited to phase correction, it should be applied to other filters as well

@lpatiny
Copy link
Member Author

lpatiny commented Oct 21, 2024

Yes this is something we should discuss but it is not urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request to discuss
Projects
Development

No branches or pull requests

2 participants