Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[carousel]: swipe gesture is buggy and inconsistent #11343

Open
andy-blum opened this issue Jan 5, 2024 · 2 comments · May be fixed by #11392
Open

[carousel]: swipe gesture is buggy and inconsistent #11343

andy-blum opened this issue Jan 5, 2024 · 2 comments · May be fixed by #11392
Assignees
@kennylam
Labels
adopter: AEM used when component or pattern will be used by this adopter bug Something isn't working dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package severity 3 Affects minor functionality, has a workaround

Comments

@andy-blum
Copy link
Contributor

andy-blum commented Jan 5, 2024 •
edited
Loading

JIRA

Description

Swipe gesture support was added in #5444 but in 2023, that UX is sub-par. We should look for ways to make the interaction smoother or consider removing it altogether.

Specific problems:

  • entire page is moved horizontally during gesture
  • carousel does not animate between contents
  • gesture must be performed very quickly to register as a gesture
@andy-blum andy-blum added bug Something isn't working severity 3 Affects minor functionality, has a workaround dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package adopter: AEM used when component or pattern will be used by this adopter owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants labels Jan 5, 2024
@andy-blum
Copy link
Contributor Author

RPReplay_Final1704477726.mp4

@kennylam kennylam linked a pull request Jan 11, 2024 that will close this issue
Draft
@RichKummer RichKummer mentioned this issue Jan 11, 2024
Open
2 tasks
@kennylam kennylam self-assigned this Jan 22, 2024
@kennylam kennylam moved this to Doing in Carbon for IBM.com Jan 22, 2024
@kennylam kennylam moved this from Doing to Review in Carbon for IBM.com Feb 19, 2024
@andy-blum
Copy link
Contributor Author

POC demo for a new carousel set up using a scroll container and CSS scroll-snap

https://carousel-updates--carbon-demos.netlify.app/

https://github.com/andy-blum/carbon-demo/tree/carousel-updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylam kennylam

Labels
adopter: AEM used when component or pattern will be used by this adopter bug Something isn't working dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package severity 3 Affects minor functionality, has a workaround
Projects
Carbon for IBM.com
Status: Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(carousel): update mobile styles kennylam/carbon-for-ibm-dotcom
2 participants
@kennylam @andy-blum