From f5836b9501fa0100e1c4775fb0b8d5dc4563fd48 Mon Sep 17 00:00:00 2001 From: Cristovao Cordeiro Date: Wed, 24 Jul 2024 13:44:47 +0200 Subject: [PATCH] chore: apply suggestions from code review Co-authored-by: Rafid Bin Mostofa --- .github/pull_request_template.md | 2 +- CONTRIBUTING.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 94d37f48b..5f361468f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -24,7 +24,7 @@ that apply. --> * [ ] I have read the [contributing guidelines]( https://github.com/canonical/chisel-releases/blob/main/CONTRIBUTING.md) -* [ ] I have tested my changes +* [ ] I have tested my changes ([see how](https://github.com/canonical/chisel-releases/blob/main/CONTRIBUTING.md#7-test-your-slices-before-opening-a-pr)) * [ ] I have already submitted the [CLA form]( https://ubuntu.com/legal/contributors/agreement) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c05f53d11..d1db90b57 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -264,7 +264,7 @@ conflicts between slice definitions files; Apart from asserting your slice definitions' formatting, you must also test them before opening a Pull Request. -Every Chisel release support the functional testing for slices via +Every Chisel release supports the functional testing for slices via [Spread](https://github.com/snapcore/spread). **We expect tests to be provided for every slice**, so please ensure you include