-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
peerDependency? #8
Comments
This would have been a good idea if I had released the first version of this rollup plug-in with this peer dependency. Therefore, I've opted to keep google closure-compiler-js as a dependency and I've released a new version of the plug-in with the latest version of it. |
It's probably worth adding badges in the @camelaissani +1 on not breaking the backwards compatibility as this would require a major version bump. However, what's the plans on semver going forward? The first here release was 1.0.0 rather than the recommended 0.y.z, however all releases have been marked on GitHub as pre-release and this seems somewhat contradictory. |
@jdonaldson10 thanks for your contribution |
A frustration of this plug-in is that it brings in its own dependency of the underlying google-closure-compiler library, currently it is using version 20160916.0.0 instead of the much newer version already in my project. Typically the solution for this is a peer dependency, to use whatever version is already in the project rather than install one zone.
How about switching to a peer dependency?
The text was updated successfully, but these errors were encountered: