Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails when there is ES6 getter in source #3

Open
camelaissani opened this issue Sep 25, 2016 · 3 comments
Open

Fails when there is ES6 getter in source #3

camelaissani opened this issue Sep 25, 2016 · 3 comments

Comments

@camelaissani
Copy link
Owner

I noticed that this code fails to be compiled:

export class Route {
    constructor(uriPart) {
        this.uriPart = uriPart;
    }

    get uri() {
        return this.uriPart;
    }
}

export class Router {};

Because of the ES6 get synthax

@camelaissani
Copy link
Owner Author

See discussion here: rollup/rollup#961

camelaissani pushed a commit that referenced this issue Sep 25, 2016
@GGG-KILLER
Copy link

GGG-KILLER commented Dec 8, 2016

Was able to make this stop happening by commenting lines 8530-8532 on node_modules/rollup/dist/rollup.js, apparently the problem is not with closure compiler but with rollup. I put the full report on the discussion (rollup/rollup#961)

@camelaissani
Copy link
Owner Author

Thanks very much for your deep investigation. I hope rollup team will give their feedback too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants