Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-3176] Add a setting to change the default home view #13778

Open
ciaranha opened this issue Feb 20, 2024 · 3 comments · May be fixed by #18392
Open

[CAL-3176] Add a setting to change the default home view #13778

ciaranha opened this issue Feb 20, 2024 · 3 comments · May be fixed by #18392
Labels
community Created by Linear-GitHub Sync ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work

Comments

@ciaranha
Copy link
Member

User request:

Friendly request to @calcom team. please make /bookings the default. I use /event-types once or twice. I visit Upcoming Bookings every time

As this is not the case for all users, instead of making it the default, we're going to make it an option that you can set:

Update default home view - New Features (Figma)

From SyncLinear.com | CAL-3176

@ciaranha ciaranha added Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Feb 20, 2024
@maige-app maige-app bot added ✨ feature New feature or request 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand labels Feb 20, 2024
@ciaranha ciaranha assigned Udit-takkar and unassigned sean-brydon Feb 20, 2024
@ciaranha ciaranha added this to the v3.9 milestone Feb 20, 2024
@Udit-takkar Udit-takkar removed the 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand label Feb 20, 2024
@ciaranha ciaranha modified the milestones: v3.9, v4.0 Feb 27, 2024
@Amit91848
Copy link
Contributor

yes please use localStorage (there is a hook for it already) and not change the database 🙏

@PeerRich won't be able to ssr here if you want to use localStorage

export async function getServerSideProps({ req, res }: GetServerSidePropsContext) {
const session = await getServerSession({ req, res });
if (!session?.user?.id) {
return { redirect: { permanent: false, destination: "/auth/login" } };
}
return { redirect: { permanent: false, destination: "/event-types" } };
}

@ciaranha ciaranha modified the milestones: v4.0, 4.1 Mar 25, 2024
@ciaranha ciaranha modified the milestones: v4.1, v4.2 Apr 16, 2024
@keithwillcode keithwillcode modified the milestones: v4.2, v4.1 May 9, 2024
@ciaranha ciaranha removed this from the v4.1 milestone May 9, 2024
@PeerRich PeerRich added this to the Community Only milestone Jun 19, 2024
@rajpatelbot
Copy link
Contributor

rajpatelbot commented Nov 2, 2024

yes please use localStorage (there is a hook for it already) and not change the database 🙏

@PeerRich won't be able to ssr here if you want to use localStorage

export async function getServerSideProps({ req, res }: GetServerSidePropsContext) {
const session = await getServerSession({ req, res });
if (!session?.user?.id) {
return { redirect: { permanent: false, destination: "/auth/login" } };
}
return { redirect: { permanent: false, destination: "/event-types" } };
}

Yes, we can't use localstorage value here as it is server component. Need to think for some better way. I have a suggession that what if we store the route value as backend cookie and set it to response header so we can use that header.

Please give your input as well.

@rajpatelbot
Copy link
Contributor

yes please use localStorage (there is a hook for it already) and not change the database 🙏

@PeerRich won't be able to ssr here if you want to use localStorage

export async function getServerSideProps({ req, res }: GetServerSidePropsContext) {
const session = await getServerSession({ req, res });
if (!session?.user?.id) {
return { redirect: { permanent: false, destination: "/auth/login" } };
}
return { redirect: { permanent: false, destination: "/event-types" } };
}

Yes, we can't use localstorage value here as it is server component. Need to think for some better way. I have a suggession that what if we store the route value as backend cookie and set it to response header so we can use that header.

Please give your input as well.

I think we should take a field in the general setting on backend side and store the default route's value there.

@PeerRich PeerRich added the community Created by Linear-GitHub Sync label Nov 24, 2024
@PeerRich PeerRich removed this from the Community Only milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Projects
None yet
7 participants