feat: ooo.new integration with DEEL #18423

ShashankGupta10 · 2024-12-30T21:11:10Z

What does this PR do?

Fixes [CAL-4945] ooo.new integration with HR tools #18311
Fixes CAL-4945

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Are there environment variables that should be set? No.
What are the minimal test data to have? None.
What is expected (happy path) to have (input and output)? DEEL has OOO Entry
Any other important info that could help to test that PR

…o shashank/ooo_new_deel_integration

vercel · 2024-12-30T21:11:15Z

@ShashankGupta10 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

graphite-app · 2024-12-30T21:15:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/30/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/30/24)

1 label was added to this PR based on Keith Williams's automation.

ShashankGupta10 · 2024-12-30T21:18:25Z

Since this is my first PR here at cal, Would love some feedback if I did make some mistakes.

Not sure that editing config.json by hand for deel app in the app-store is correct. What is the correct way?
Also i am not able to obtain the HRIS profile id from deel since i dont have a business account. Any help here would be appreciated

Drafted the PR for these reasons.

Edit - will fix the code for type checks and tests that are failing first

Praashh

type checks are failing, @ShashankGupta10 can you please fix it?

Praashh · 2024-12-31T05:11:53Z

packages/app-store/deel/api/add.ts

we should have proper handling using tryCtach

Praashh · 2024-12-31T05:14:29Z

packages/app-store/deel/api/add.ts

+  await throwIfNotHaveAdminAccessToTeam({ teamId: Number(teamId) ?? null, userId: req.session.user.id });
+  const installForObject = teamId ? { teamId: Number(teamId) } : { userId: req.session.user.id };


there should be null check for session.user.id.

I think the check at lines 9-11 is for that purpose

can you please attach a loom video as well @ShashankGupta10

Yeah sure. But I had a doubt. I dont have a DEEL business account and hence cannot get the hris_profile_id. Any other way to test it maybe? @Praashh or @PeerRich

not sure but try if you can get some test (dummy) key id for that.

Tried but could not find anything actually. Will try again and get back to you tomorrow

…o shashank/ooo_new_deel_integration

…m/ShashankGupta10/cal.com into shashank/ooo_new_deel_integration

ShashankGupta10 · 2025-01-02T20:37:23Z

This is what I found.

The DEEL API also expects a time_off_type_id which is a UID of the timeoff type you can create in DEEL itself.
You can get the valid time_off_type_id's for that user by making a request to the DEEL API providing the HRIS profile ID of the user wanting to create a time off request.
Our current ooo.new platform has a list of reasons you can have for the timeoff. This will not work since you should only be able to select the time off types that are allowed for you in DEEL.

This is "IF YOUR ORGANIZTION IS CONNECTED TO DEEL" from the cal app-store

What we can do is we can keep everything same for the users not connected to DEEL,
But for the people who are connected to deel, we change the dropdown to the allowed time off types.
BUT we will have to change the table in the DB accordingly coz right now it stores only some reasons like Vacation, sick leave etc.

Any ideas on how we should proceed? I will make the changes in this PR accordingly

References:
https://developer.deel.com/docs/time-off#update-a-time-off-request-for-a-worker
https://developer.deel.com/reference/getpoliciesforprofile
https://developer.deel.com/reference/createtimeoff

Praashh · 2025-01-05T22:39:38Z

This is what I found.

The DEEL API also expects a time_off_type_id which is a UID of the timeoff type you can create in DEEL itself.

You can get the valid time_off_type_id's for that user by making a request to the DEEL API providing the HRIS profile ID of the user wanting to create a time off request.

Our current ooo.new platform has a list of reasons you can have for the timeoff. This will not work since you should only be able to select the time off types that are allowed for you in DEEL.

This is "IF YOUR ORGANIZTION IS CONNECTED TO DEEL" from the cal app-store

What we can do is we can keep everything same for the users not connected to DEEL,

But for the people who are connected to deel, we change the dropdown to the allowed time off types.

BUT we will have to change the table in the DB accordingly coz right now it stores only some reasons like Vacation, sick leave etc.

Any ideas on how we should proceed? I will make the changes in this PR accordingly

References: https://developer.deel.com/docs/time-off#update-a-time-off-request-for-a-worker https://developer.deel.com/reference/getpoliciesforprofile https://developer.deel.com/reference/createtimeoff

not sure tbh

ShashankGupta10 · 2025-01-06T06:23:10Z

@PeerRich sorry for tagging again but help needed!

PeerRich · 2025-01-06T09:56:37Z

i dont know personally. there is a chance one of our team members has to take over this PR and get the IDs from deel

ShashankGupta10 added 7 commits December 28, 2024 18:22

🚚: add form for getting API key

2ec8846

Merge branch 'main' of https://github.com/ShashankGupta10/cal.com int…

d8329c0

…o shashank/ooo_new_deel_integration

🚚: add API keys save in DB

fd3a9c3

🚚: remove log statements

f2f596f

🚚: remove .env and let it be a symlink

6e3af7b

🚚: add entry in deel

848e8bb

🚚: oops.

9d953a1

graphite-app bot added the community Created by Linear-GitHub Sync label Dec 30, 2024

graphite-app bot requested a review from a team December 30, 2024 21:11

github-actions bot added High priority Created by Linear-GitHub Sync ✨ feature New feature or request labels Dec 30, 2024

dosubot bot added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label Dec 30, 2024

ShashankGupta10 marked this pull request as draft December 30, 2024 21:11

Praashh requested changes Dec 31, 2024

View reviewed changes

Praashh reviewed Dec 31, 2024

View reviewed changes

packages/app-store/deel/api/add.ts

Copy link

Contributor

Praashh Dec 31, 2024 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have proper handling using tryCtach

Praashh reviewed Dec 31, 2024

View reviewed changes

ShashankGupta10 added 2 commits December 31, 2024 15:56

Merge branch 'main' of https://github.com/ShashankGupta10/cal.com int…

ad4310e

…o shashank/ooo_new_deel_integration

🚚: try to fix type check

497e0b0

ShashankGupta10 force-pushed the shashank/ooo_new_deel_integration branch from 268c2fc to 497e0b0 Compare December 31, 2024 10:40

ShashankGupta10 added 6 commits December 31, 2024 16:38

🚚: fix unit test

533d3ca

🚚: try to fix unit test

a05f108

🚚: try to fix test - 2

521fadd

🚚: fix unit test

f610caf

🚚: make requested changes

e794f85

Merge branch 'main' into shashank/ooo_new_deel_integration

59344b8

ShashankGupta10 marked this pull request as ready for review December 31, 2024 20:10

🚚: fix type-check

aa74d15

Merge branch 'shashank/ooo_new_deel_integration' of https://github.co…

401a278

…m/ShashankGupta10/cal.com into shashank/ooo_new_deel_integration

ShashankGupta10 marked this pull request as draft January 2, 2025 19:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ooo.new integration with DEEL #18423

feat: ooo.new integration with DEEL #18423

ShashankGupta10 commented Dec 30, 2024 •

edited

Loading

vercel bot commented Dec 30, 2024

graphite-app bot commented Dec 30, 2024

ShashankGupta10 commented Dec 30, 2024 •

edited

Loading

Praashh left a comment

Praashh Dec 31, 2024 •

edited

Loading

Praashh Dec 31, 2024

ShashankGupta10 Dec 31, 2024

Praashh Jan 1, 2025

ShashankGupta10 Jan 2, 2025

Praashh Jan 2, 2025

ShashankGupta10 Jan 2, 2025

ShashankGupta10 commented Jan 2, 2025

Praashh commented Jan 5, 2025

ShashankGupta10 commented Jan 6, 2025

PeerRich commented Jan 6, 2025

		await throwIfNotHaveAdminAccessToTeam({ teamId: Number(teamId) ?? null, userId: req.session.user.id });
		const installForObject = teamId ? { teamId: Number(teamId) } : { userId: req.session.user.id };

feat: ooo.new integration with DEEL #18423

Are you sure you want to change the base?

feat: ooo.new integration with DEEL #18423

Conversation

ShashankGupta10 commented Dec 30, 2024 • edited Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

vercel bot commented Dec 30, 2024

graphite-app bot commented Dec 30, 2024

Graphite Automations

ShashankGupta10 commented Dec 30, 2024 • edited Loading

Praashh left a comment

Choose a reason for hiding this comment

Praashh Dec 31, 2024 • edited Loading

Choose a reason for hiding this comment

Praashh Dec 31, 2024

Choose a reason for hiding this comment

ShashankGupta10 Dec 31, 2024

Choose a reason for hiding this comment

Praashh Jan 1, 2025

Choose a reason for hiding this comment

ShashankGupta10 Jan 2, 2025

Choose a reason for hiding this comment

Praashh Jan 2, 2025

Choose a reason for hiding this comment

ShashankGupta10 Jan 2, 2025

Choose a reason for hiding this comment

ShashankGupta10 commented Jan 2, 2025

Praashh commented Jan 5, 2025

ShashankGupta10 commented Jan 6, 2025

PeerRich commented Jan 6, 2025

ShashankGupta10 commented Dec 30, 2024 •

edited

Loading

ShashankGupta10 commented Dec 30, 2024 •

edited

Loading

Praashh Dec 31, 2024 •

edited

Loading