Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Shouldn't --wit-dir also change the place where we look-up for wkg.(toml|lock)? #137

Open
raskyld opened this issue Dec 8, 2024 · 3 comments

Comments

@raskyld
Copy link

raskyld commented Dec 8, 2024

Hello!

I have a repo with multiple WIT packages, I use this option, so I can build my different package.

I noticed that we use the default (Lock|Config)::load(), but should we instead use this function to load from the dir passed to --wit-dir?

If so, I would be happy to contribute back a quick MR! ❤️

@thomastaylor312
Copy link
Collaborator

I've gone back and forth on what the best behavior and location would be here. Other .lock files are almost always at the top level of a project, but also, wit is kinda half way between a vendor/node_modules dir and configuration. The other use case I see here is where you do want things at the top level (current behavior), but your wit directory is not in the standard location.

@joonas @calvinrp curious if you have any thoughts here

@raskyld
Copy link
Author

raskyld commented Dec 12, 2024

If that may bring any perspective, in my specific use-case, I have different packages in a repository.

What you describe "things at the root" sounds more like the equivalent of "workspaces" in Cargo and go modules.

@thomastaylor312
Copy link
Collaborator

Yeah for sure @raskyld! That is what I am trying to tease out. I've seen people use it both ways. Just trying to figure out where the right place would be to store it and why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants