We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi @wenyongh @lum1n0us @loganek @jammar1 I’m currently implementing local.set / get for v128 to finish off the simd work for fast interpreter
I looked at how it’s done for 32 and 64 bit types and I see that we use separate opcodes for that
https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/core/iwasm/interpreter/wasm_opcode.h#L255
The easiest way for me then would be to add the similar opcode for v128 (EXT_OP_SET_LOCAL_FAST_V128) and do the handling in fast_interp (extending https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/core/iwasm/interpreter/wasm_loader.c#L12927) , however I have no opcode space (i.e. all 0xc opcodes are already used)
I think my options are pretty much limited to:
WASM_OP_GET_LOCAL
EXT_OP_SET_LOCAL_FAST_V128
EXT_OP_SET_LOCAL_FAST_I64
I think I should stick to option 1 but wanted to gather your opinion first
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi @wenyongh @lum1n0us @loganek @jammar1
I’m currently implementing local.set / get for v128 to finish off the simd work for fast interpreter
I looked at how it’s done for 32 and 64 bit types and I see that we use separate opcodes for that
https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/core/iwasm/interpreter/wasm_opcode.h#L255
The easiest way for me then would be to add the similar opcode for v128 (EXT_OP_SET_LOCAL_FAST_V128)
and do the handling in fast_interp (extending https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/core/iwasm/interpreter/wasm_loader.c#L12927) , however I have no opcode space (i.e. all 0xc opcodes are already used)
I think my options are pretty much limited to:
WASM_OP_GET_LOCAL
in the interpreter (e.g. don’t fast-process it in loader for V128)EXT_OP_SET_LOCAL_FAST_V128
. I am not sure whether it’s a safe thing to do but I would probably avoid doing itEXT_OP_SET_LOCAL_FAST_I64
instead of V128. I think it's going to be quite confusing and risky if possible at allI think I should stick to option 1 but wanted to gather your opinion first
The text was updated successfully, but these errors were encountered: