You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to blinker's documentation the .send method expects the first argument to be the sender object. bw2data's implementation is inconsistent with the documentation and within itself.
For example in signals.py, the sender argument is omitted, meaning it will be set as None. This makes using the sender argument in blinker's .connect method impossible.
In project.py the project dataset is passed through the sender arg, which is of course not how it should be used. This again breaks blinkers .connect method and is inconsistent with the earlier example.
According to blinker's documentation the
.send
method expects the first argument to be the sender object. bw2data's implementation is inconsistent with the documentation and within itself.For example in
signals.py
, the sender argument is omitted, meaning it will be set asNone
. This makes using thesender
argument in blinker's.connect
method impossible.brightway2-data/bw2data/signals.py
Lines 249 to 253 in 4fd8e93
In
project.py
the project dataset is passed through thesender
arg, which is of course not how it should be used. This again breaks blinkers.connect
method and is inconsistent with the earlier example.brightway2-data/bw2data/project.py
Line 374 in 4fd8e93
Blinkers documentation for reference: https://blinker.readthedocs.io/en/stable/#blinker.Signal.send
The text was updated successfully, but these errors were encountered: