Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken IOTable backend #215

Open
mfastudillo opened this issue Dec 10, 2024 · 1 comment
Open

broken IOTable backend #215

mfastudillo opened this issue Dec 10, 2024 · 1 comment

Comments

@mfastudillo
Copy link
Contributor

I've created a fresh virtual environment that installed bw2data version 4.0 and the importer I created for the IO Tables broke. I suspect it broke the IOTable backend in general. Running the write_database() method inspired in the Exiobase3MonetaryImporter returns a type error:

TypeError: IOTableBackend.write() got an unexpected keyword argument 'signal'

I tried with the previous version 4.0.dev60 and it works

@mfastudillo
Copy link
Contributor Author

I imagine it can be solved slightly modifying the write method of the IOTable backend which currently is something like:

def write(self, data, process=False, searchable=True, check_typos=True):
    super().write(data, process=False, searchable=searchable, check_typos=check_typos)

maybe something like would do, but I am unfamiliar with blinker

def write(self, data, process=False, searchable=True, check_typos=True,signal=None):
    super().write(data, process=False, searchable=searchable, check_typos=check_typos,signal=signal)

@cmutel ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant