Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Box2DPhysicsBody.enabled will emit "enabled_state_changed" signal, unlike awake property #49

Open
briansemrau opened this issue Dec 24, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@briansemrau
Copy link
Owner

This is because we do not set prev_enabled_state in set_enabled. This may be favorable for some people, but it is not consistent with the behavior for sleeping state (which aligns with the intended Godot physics behavior to not emit the signal when manually modified).

@briansemrau briansemrau added the bug Something isn't working label Dec 24, 2020
@briansemrau
Copy link
Owner Author

Okay so when writing this I totally forgot why we even have the signal, which is to update fixture debug draw. However, from an application dev perspective this signal still does not make any sense to use. Perhaps this could be refactored to not use outward-facing signals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant