Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box2DJoint debug drawing issues #48

Open
briansemrau opened this issue Dec 24, 2020 · 0 comments
Open

Box2DJoint debug drawing issues #48

briansemrau opened this issue Dec 24, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@briansemrau
Copy link
Owner

briansemrau commented Dec 24, 2020

Error spam problem:
In some of the Box2DJoint debug draw functions, there are missing checks for if the joint is valid before trying to get certain values.

Cleanliness:
Debug drawing for joints contains lots of similar code for each joint. It would be nice to clean this up.

Transform problems:
At least when working with prismatic joints, the geometry drawn for the constraints between two rotating bodies is rotated at double the angle it should (simply: it draws in the wrong spot). This should be fixed alongside the cleanliness issue to prevent silly bugs like this when all the other joints get implemented.

@briansemrau briansemrau added the bug Something isn't working label Dec 24, 2020
@briansemrau briansemrau changed the title "b2Joint is null" error spam Box2DJoint debug drawing issues Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant