-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand_keys support for JSON arrays #71
Comments
what is the desired behavior for an array? expand |
As metioned in the Readme: |
Yea, my comments is just to point out it doesn't seem to have any good way to support array. |
Ah, gotcha! |
The reference for this particular case is in here: /lib/consul/index.js#L65. I'm closing because there is no good answer on handling the expected/desired outcome of an array. Aside from the point mentioned by @arthurtsang, arrays can contain repeat values. In that case, what would the the appropriate value to keep - the first, the last, or some other value by a certain criteria? |
I loaded the sample git2consul configuration file into git.
I configured git2consul to monitor this file and the end result in Consul is only version makes it into Consul:
It would be nice if git2consul could handle arrays. Thanks!
The text was updated successfully, but these errors were encountered: