Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages should not display dark text in dark mode #1473

Open
cdw9 opened this issue Nov 19, 2024 · 7 comments
Open

Pages should not display dark text in dark mode #1473

cdw9 opened this issue Nov 19, 2024 · 7 comments
Assignees
Labels
Appearance Bug Something isn't working

Comments

@cdw9
Copy link
Collaborator

cdw9 commented Nov 19, 2024

@cdw9 cdw9 self-assigned this Nov 19, 2024
@cdw9 cdw9 added this to website-v2 Nov 19, 2024
@julioest
Copy link
Collaborator

julioest commented Nov 25, 2024

@rbbeeston is this is a Won't Fix? (For now)

@rbbeeston
Copy link
Member

No, It needs to be addressed, even if it ends up being fixed as part of another ticket, it should be linked to this one before being closed out.

@julioest julioest moved this to Accepted in website-v2 Nov 25, 2024
@cdw9 cdw9 assigned rbbeeston and unassigned cdw9 Dec 16, 2024
@cdw9
Copy link
Collaborator Author

cdw9 commented Dec 16, 2024

@rbbeeston I think you ended up saying this one wouldn't be fixed. Can you confirm?

@rbbeeston rbbeeston added Bug Something isn't working Appearance labels Dec 16, 2024
@rbbeeston
Copy link
Member

It should have boostlook applied to it, that should fix it. @julioest can you confirm?

@julioest
Copy link
Collaborator

This library does not have the boostlook class applied.

@rbbeeston
Copy link
Member

@julioest yes, I know it doesn't but I believe it should have it. What needs to happen to add it?

@julioest
Copy link
Collaborator

@rbbeeston The logic responsible for wrapping the doc elements needs to be modified still. This is tied to Dave's work of identifying doc types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Appearance Bug Something isn't working
Projects
Status: Accepted
Development

No branches or pull requests

3 participants