Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

Is --no-check-certificate necessary? #42

Open
dxgldotorg opened this issue May 23, 2021 · 3 comments
Open

Is --no-check-certificate necessary? #42

dxgldotorg opened this issue May 23, 2021 · 3 comments

Comments

@dxgldotorg
Copy link

dxgldotorg commented May 23, 2021

The assets are downloaded from raw.githubusercontent.com which has valid SSL certificates; if a certificate error occurs that means there is something wrong.

Or is the "Great Firewall" damaging your connections? Because those in the rest of the world can probably omit that command line parameter safely.

@bigtreetech
Copy link
Owner

However, it worked fine in our installation tests, unless it was caused by a network failure, if you failed to run, you can try to cancel the run parameter.

@dxgldotorg
Copy link
Author

Adding --no-check-certificate bypasses the security features of HTTPS, and if it isn't required should be omitted.

@Shine6Z
Copy link
Contributor

Shine6Z commented Jul 19, 2021

Of course, in order to ensure that everyone can use it normally, I don't think this option should be cancelled, because there is no reason for this option to harm the interests of users. If there is, I will change other methods to ensure the safety of users. If you have a better way, I will introduce it into the project after testing confirmation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants