Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM #2

Open
devloic opened this issue Jul 6, 2023 · 2 comments
Open

ARM #2

devloic opened this issue Jul 6, 2023 · 2 comments

Comments

@devloic
Copy link

devloic commented Jul 6, 2023

Hi Tobias,

what would it need to make your tool work with arm images?

Update:
I tried to compile your main.go on arm but not luck, modules are deprecated ( dockerignore ) , its a real mess (not your code but the go packaging system). It might be easier to migrate the code but I feel that taking a deeper look at the nixos side might be more useful on the long run. Meanwhile I decided to try to merge two arm images and it actually worked on my system (macos).

@bergkvist
Copy link
Owner

This is probably just a matter of detecting desired cpu architecture here instead of hard-coding Architecture: "amd64":

includeimage/main.go

Lines 58 to 63 in 670f86d

// TODO: Get current platform
_, dt, err := imagemetaresolver.Default().ResolveImageConfig(ctx, ref.String(), llb.ResolveImageConfigOpt{
Platform: &specs.Platform{Architecture: "amd64", OS: "linux"},
LogName: "[imageinclude] load metadata for " + ref.String(),
ResolveMode: "default",
})

@PipGrylls
Copy link

Did this get/could this be pushed into the docker-hub?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants