Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting line height for base style is not working #40

Open
lpellegr opened this issue Feb 21, 2020 · 1 comment
Open

Setting line height for base style is not working #40

lpellegr opened this issue Feb 21, 2020 · 1 comment

Comments

@lpellegr
Copy link

First of all, thanks for this nice wrapper! Unfortunately, it seems that setting a line-height for the base style with --stripe-elements-base-line-height is not working properly. Once set, the stripe-elements element is always growing to 150px in height.

Here is a small example to reproduce the issue:

https://codesandbox.io/s/stripe-elements-web-component-lit-element-42rfv

@bennypowers
Copy link
Owner

Hello!
Thank you for opening this issue, and thank you for providing a reproduction.

I can see that indeed the line-height is set properly:

Screen Shot 2020-02-22 at 22 22 04

Something else is causing the container to take on 150px height. I wasn't yet able to track down exactly what is causing that.

The Stripe.js docs advise against using line-height anyways, perhaps consider setting padding

stripe-elements::part(stripe) {
  padding: 16px 18px;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants