Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name parts with number less 10 with a leading zero #97

Open
olegstepura opened this issue Dec 19, 2015 · 9 comments
Open

Name parts with number less 10 with a leading zero #97

olegstepura opened this issue Dec 19, 2015 · 9 comments

Comments

@olegstepura
Copy link
Contributor

Now github orders files the wrong way. I suggest solving this by adding a leading zero to numbers < 10

Before:

part1.md
part10.md
part11.md
part12.md
part13.md
part14.md
part2.md
part3.md
part4.md
part5.md
part6.md
part7.md
part8.md
part9.md

After

part01.md
part02.md
part03.md
part04.md
part05.md
part06.md
part07.md
part08.md
part09.md
part10.md
part11.md
part12.md
part13.md
part14.md
@bagder
Copy link
Owner

bagder commented Dec 19, 2015

Right, but does it really matter in which order github shows them?

@olegstepura
Copy link
Contributor Author

I was reading it on github. Ordering did matter. After part 9 I had to scroll back to top to find part 10. I could think there is no part 10 at all. If there would be a link #98, it would be even better.

@bagder
Copy link
Owner

bagder commented Dec 19, 2015

Oh, you were reading it on github... Can I ask you why you read it here? The book renders much better on the actual book site.

@olegstepura
Copy link
Contributor Author

I found it here and read it here =)

@bagder
Copy link
Owner

bagder commented Dec 19, 2015

Try reading the book at http://http2-explained.haxx.se/ instead =)

@olegstepura
Copy link
Contributor Author

BTW github renders thing very well, so reading it on github is ok. Maybe I'm the only one who did it this way, but I only suggest after reading all book and having some experience. Others may be just lazy enough to suggest such things ;)

@bagder
Copy link
Owner

bagder commented Dec 19, 2015

Oh sure, I appreciate the feedback, I don't mean to imply anything else. It's just that a kind of "next chapter" link makes less sense in a PDF version or in the html version as it is rendered on http2-explained.haxx.se so I'm not sure how to do it to make it nice all over.

@olegstepura
Copy link
Contributor Author

Well, it's up to you, actually. I cannot insist. Tha't why I opened an issue, not a pull request: to discuss this option.

@olegstepura
Copy link
Contributor Author

Ok, just close the #98 issue as won't fix ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants