Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to remote calls #95

Open
tjkirch opened this issue Aug 18, 2021 · 0 comments
Open

Add timeout to remote calls #95

tjkirch opened this issue Aug 18, 2021 · 0 comments

Comments

@tjkirch
Copy link
Contributor

tjkirch commented Aug 18, 2021

We've seen a few occasions where coldsnap uploads have blocked forever in a rusoto call. We should add timeouts so the calls can fail, letting the error handling code either retry or inform the user.

tokio::time::timeout can wrap any future with a maximum duration; we can use it to wrap our rusoto calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant