Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt-buffer: do-what-I-mean selection position during a single update #31

Open
Ambrevar opened this issue Jul 25, 2021 · 3 comments
Open

Comments

@Ambrevar
Copy link
Member

Ambrevar commented Jul 25, 2021

It's OK to reset the current suggestion when the input changes, but we can do better: if the new input includes the former current suggestion, it should be re-set if the user hasn't changed it in the mean time.

Conversely, some suggestion updates may be slow for a single input change and take multiple "cycles". In this case, the user should be able to set the current suggestion while the suggestions are still updating, and each update cycle should not change the current suggestion.

@aadcg
Copy link
Member

aadcg commented May 30, 2023

If I understood this correctly, we already provide this feature. See the clip below.

simplescreenrecorder-2023-05-30_12.25.20.mp4

@aadcg aadcg closed this as completed May 30, 2023
@Ambrevar
Copy link
Member Author

Ambrevar commented May 30, 2023

I'ts not about marking but about the current suggestion.

@Ambrevar Ambrevar reopened this May 30, 2023
@aadcg
Copy link
Member

aadcg commented May 30, 2023

I'll update the original post with the new prompt buffer terminology.

@aartaka aartaka closed this as completed May 30, 2023
@aadcg aadcg transferred this issue from atlas-engineer/nyxt Oct 25, 2023
@aadcg aadcg reopened this Oct 25, 2023
@atlas-engineer atlas-engineer deleted a comment from aartaka Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants