Login not preserved between buffers Nyxt 4+

[fictitiousexistence]

Describe the bug
With nyxt 4+/git , when opening a link to the same site in a new buffer you will not be logged in. Works on 3.12.0

Precise recipe to reproduce the issue

• Open nyxt
  nyxt -CI
• Go to https://github.com/atlas-engineer/nyxt/issues
• Sign into github.
• Open any of the issues in a new buffer by either right clicking and selecting "Open Link in New Buffer" or by holding control while clicking link.
• Switch to just opened buffer- see that you are signed out.

Information

• OS name+version: gentoo
• Graphics card and driver:
• Desktop environment / Window manager name+version: dwl
• Installation method (Flatpak, Guix, package manager, build from source): source
• Output of nyxt --system-information:

Nyxt version: 4
Web Renderer: GI-GTK
OS: Linux 6.12.6-gentoo
Lisp implementation: SBCL 2.4.11 (Dynamic space: 3072MB)
ASDF version: 3.3.5
Features: (:NYXT-GI-GTK :NYXT-GTK :NYXT-GI-GTK :NYXT-GTK :WEBKIT2 :WEBKIT-2.46.5
 :WEBKIT-2.46 :WEBKIT-2 :WEBKIT2-CORS-ALLOWLIST :WEBKIT2-PASTE-PLAINTEXT
 :WEBKIT2-TRACKING :WEBKIT2-MUTE :WEBKIT2-EMOJI :WEBKIT2-MEDIA
 :WEBKIT2-SANDBOXING :GTK-3-22 :GTK-3-20 :GTK-3-18 :GTK-3-16 :GTK-3-14
 :GTK-3-12 :GTK-3-10 :GTK-3-8 :GTK-3-6 :GTK-3-4 :GTK :GDK-3-22 :GDK-3-20
 :GDK-3-18 :GDK-3-16 :GDK-3-14 :GDK-3-12 :GDK-3-10 :GDK-3-8 :GDK-3-6 :GDK-3-4
 :CAIRO-1-10 :CAIRO-1-12 :GDK-PIXBUF :GLIB-2-30 :GLIB-2-32 :GLIB-2-34
 :GLIB-2-36 :GLIB-2-38 :GLIB-2-40 :GLIB-2-42 :GLIB-2-44 :GLIB-2-46 :GLIB-2-48
 :GLIB-2-50 :GLIB-2-52 :GLIB-2-54 :GLIB-2-56 :GLIB-2-58 :GLIB :NYXT-4
 :CLIPBOARD-CONTENT-METHOD :SWANK :SLYNK :PLUMP-UTF-32 :PARENSCRIPT :NSYMBOLS
 :FSET-EXT-STRINGS :SBCL+SAFE-STANDARD-READTABLE :NAMED-READTABLES :GLOBAL-VARS
 :LPARALLEL :21BIT-CHARS :CUSTOM-HASH-TABLE-NATIVE :CLOSER-MOP
 :CL-PPCRE-UNICODE :CL-UNICODE :CL-JSON-DOUBLE-FLOAT-IS-SUBSUMED
 :CL-JSON-SINGLE-FLOAT-IS-SUBSUMED :CHUNGA :FLEXI-STREAMS :CL-PPCRE
 :BORDEAUX-THREADS :LPARALLEL.WITH-CLTL2 :LPARALLEL.WITH-CAS
 :LPARALLEL.WITH-STEALING-SCHEDULER :SPLIT-SEQUENCE
 CFFI-FEATURES:FLAT-NAMESPACE CFFI-FEATURES:X86-64 CFFI-FEATURES:UNIX :CFFI
 CFFI-SYS::FLAT-NAMESPACE ALEXANDRIA::SEQUENCE-EMPTYP :FAST-IO-SV :FAST-IO
 :CL-JSON-CLOS :CL-JSON :SBCL-USES-SB-ROTATE-BYTE CHIPZ-SYSTEM:GRAY-STREAMS
 :THREAD-SUPPORT :ASDF3.3 :ASDF3.2 :ASDF3.1 :ASDF3 :ASDF2 :ASDF :OS-UNIX
 :NON-BASE-CHARS-EXIST-P :ASDF-UNICODE :ARENA-ALLOCATOR :X86-64 :GENCGC :64-BIT
 :ANSI-CL :COMMON-LISP :ELF :IEEE-FLOATING-POINT :LINUX :LITTLE-ENDIAN
 :PACKAGE-LOCAL-NICKNAMES :SB-CORE-COMPRESSION :SB-LDB :SB-PACKAGE-LOCKS
 :SB-THREAD :SB-UNICODE :SBCL :UNIX)

Output when started from a shell

[aadcg]

Thanks for reporting @fictitiousexistence.

The culprit is c3e5d89. I'll take a look.

[fictitiousexistence]

@aadcg I tested and this does fix it for the example I provided with github however, the issue remains for any sites using Apache's Basic HTTP authentication.

I have not been able to find a public site as an example yet. All the sites I am having the issue with are all internal/company sites using Apache's basic auth.

[fictitiousexistence]

@aadcg I couldn't find any public sites for testing this with so I just threw a test site together quick.

url: https://test.redshat.com/
user: username
pass: password

Then just open any links in new tab.

Thanks.

[aadcg]

The test site doesn't seem to work for me.

the issue remains for any sites using Apache's Basic HTTP authentication

Just to be sure: in this situation, does it work on 3.12.0?

[fictitiousexistence]

Sorry. I forgot my firewall rules are pretty strict. I relaxed them so you might be able to get to the test site now.

Yes, works in 3.12.0

[aadcg]

Sorry. I forgot my firewall rules are pretty strict. I relaxed them so you might be able to get to the test site now.

No luck still.

[fictitiousexistence]

:( It was a dumb issue with dns. https://redshat.com should work.

[fictitiousexistence]

I was able to find 2 other sites that don't use Apaches basic auth that have the same issue.

namecheap.com
gitlab.com (or any gitlab instance)

Thanks.