Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalFileModelRepository - Add support for "safe names" for predictable file paths #259

Open
mbrdev opened this issue Aug 8, 2020 · 1 comment

Comments

@mbrdev
Copy link

mbrdev commented Aug 8, 2020

Is your feature request related to a problem? Please describe.
Currently we are using things like Experiment Name and Deployment Name as part of file paths in the LocalFileModelRepository, if either of these names contain invalid characters for a file system path then we will be unable to save the files.

Describe the solution you'd like

  • Experiments would have a "safe name" that can be used in URLs and file paths, it would only support alphanumeric, hyphens, underscores and dot characters.
  • Deployments would have a "safe name" that can be used in URLs and file paths, it would only support alphanumeric, hyphens, underscores and dot characters.
  • All folder paths and/or URLs would use these safe names.

Describe alternatives you've considered

  • We discussed cleaning the names to remove any invalid character from the path, this however would result in unpredictable file paths
  • We discussed using just the IDs to form the paths but then this would make all paths unreadable
  • We discussed restricting the characters that can be used for naming but this may be undesired to change UI behaviour and display based on file system requirements
@aslotte
Copy link
Owner

aslotte commented Oct 3, 2020

@mbrdev would it make sense to create a service that generates safe names and we can use that where we need to have a safe name of a deployment target, expeiment and so forth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants