-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use always latest versions in distribution #1227
Comments
Answering #1223 (comment)
Yes, testing compatibility is tricky. I agree that it's more than compiling and that we can at most cover some common scenarios. But I don't think semver applies here. Following the Boot example, recently snakeyaml was bumped from v1.33 to v2.0 in all branches (v2.7 and v3.x). As a Boot consumer you don't care about third-party dependencies it brings, and that's how I see the other asciidoctorj-* components in the distribution. It's true snakeyaml was a bit of a special case and in general major bumps even for third-party libs are not wanted, but not uncommon either. Now, maybe the question is how we should deal with this here. It's not a bad idea to lock to the versions to the one on release. So that Asciidoctorj 2.5.0 started with j-pdf 1.6.x, they should go together. |
That's too funny, because I had exactly that example on my mind :D However, looking at the release notes for asciidoctor-pdf 2.0.0 it seems like this was only done to mark the official start for going with semver. |
You were convincing me now, it seems I do not understand Boot policies. But in the end, I still think we should use the latest to lower our work and cognitive load. |
We are maintaining different versions of the dependencies (asciidoctorj-pdf, asciidoctorj-diagram, ...) for branches
main
andv2.5.x
.For example:
My proposal is to align the distribution with the latest always. So long is compatible there are no blockers.
PS: this was brought here around the update of the docs properties. Related to that, I don't think the properties are used in the docs at all.
The text was updated successfully, but these errors were encountered: