New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The extension should set `docfile` and `docdir` instead of `base_dir` #926

Open

ggrossetie opened this issue Dec 28, 2024 · 0 comments

Labels

✨ enhancement

Member

ggrossetie commented Dec 28, 2024

Original discussion: https://asciidoctor.zulipchat.com/#narrow/channel/279642-users/topic/Base.20directory.20and.20IDE/near/421004097

base_dir is basically a design bug in Asciidoctor (or perhaps we can say for niche situations). It should never be used unless you absolutely know why you are using it. Setting it breaks relative includes. If docdir is set, it should be capable of doing all the work that is necessary.
-- Dan Allen

I don't think I set it, browsed the code and didn't find it. I set only docfile (current file to be rendered for the preview) and docdir (the folder where the file is located).
-- Alexander Schwartz

That's the correct way.
-- Dan Allen

ggrossetie added the ✨ enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment