Argo Workflows: CRDs do not preserve unknown fields anymore

[chrko]

Describe the bug

The update of argo workflows here to v3.6.0 (#3037) also updated the CRDs. Unfortunately this causes issues, e.g. for values in the wfeb.spec.submit.metadata section (

argo-helm/charts/argo-workflows/templates/crds/argoproj.io_workfloweventbindings.yaml

Lines 669 to 670 in 27ef4ec

	metadata:
	type: object

). Previous to the update no validation has been performed (

argo-helm/charts/argo-workflows/templates/crds/argoproj.io_workfloweventbindings.yaml

Line 37 in 5a57de4

x-kubernetes-preserve-unknown-fields: true

)

"Upstream" this has been fixed a few days ago by adding the missing fields in the CRDs: argoproj/argo-workflows#14044

Instead of awaiting the next release, I'd like to propose to only update the CRDs to the fixed versions. In case noone objects, I'll prepare a PR tomorrow (CET).

Related helm chart

argo-workflows

Helm chart version

0.45.x

To Reproduce

Apply the following manifest:

apiVersion: argoproj.io/v1alpha1
kind: WorkflowEventBinding
metadata:
  name: pipeline-svc-workflow-webhook-server-change
spec:
  event:
    selector: not payload.deleted
  submit:
    arguments:
      parameters:
        - name: name
          valueFrom:
            event: payload.repository.name
        - name: url
          valueFrom:
            event: payload.repository.ssh_url
        - name: ref
          valueFrom:
            event: payload.ref
        - name: refName
          valueFrom:
            event: payload.ref | split("/") | last()
        - name: eventType
          valueFrom:
            event: (payload.ref|split("/"))[1]
        - name: checkoutSha
          valueFrom:
            event: payload.after
    metadata:
      labels:
        app.ci.project: payload.repository.name
        app.ci.ref: payload.ref | split("/") | last()
        app.ci.sha: payload.after
      name: >-
        "ci-" + payload.repository.name + "-" + (payload.ref | split("/") |
        last()) + "-" + (now().Unix() | string())
    workflowTemplateRef:
      name: pipeline-svc-workflow-ci

Let k8s complain:

The request is invalid: patch: Invalid value: […]: strict decoding error: unknown field "spec.submit.metadata.labels", unknown field "spec.submit.metadata.name"

Expected behavior

WorkflowEventBinding is accepted by k8s api.

Screenshots

No response

Additional context

No response

[yu-croco]

Hi @chrko , thank you for opening the issue.

"Upstream" this has been fixed a few days ago by adding the missing fields in the CRDs: argoproj/argo-workflows#14044

Instead of awaiting the next release, I'd like to propose to only update the CRDs to the fixed versions. In case noone objects, I'll prepare a PR tomorrow (CET).

Our policy is to follow upstream's version. Once upstream releases the fixed code with version tag, we will follow it.