Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ui test to fix logic for headless mode, add some log messages, misc. #21361

Open
1 of 3 tasks
keithchong opened this issue Jan 3, 2025 · 0 comments · May be fixed by #21362
Open
1 of 3 tasks

Update ui test to fix logic for headless mode, add some log messages, misc. #21361

keithchong opened this issue Jan 3, 2025 · 0 comments · May be fixed by #21362
Assignees
@keithchong
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements

Comments

@keithchong
Copy link
Contributor

Fixes to ui-tests

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

Logic for headless mode is not quite right. Env var specifically says false or true. If false, browser will appear. If true or if env var is not defined, it will be headless.

Also will include some logs to help in diagnosing error conditions in the create app panel.
@keithchong keithchong added the bug Something isn't working label Jan 3, 2025
@keithchong keithchong self-assigned this Jan 3, 2025
@keithchong keithchong added the component:ui User interfaces bugs and enhancements label Jan 3, 2025
keithchong added a commit to keithchong/argo-cd that referenced this issue Jan 3, 2025
@keithchong
test: Update ui test to fix logic for headless mode, add logs (argopr…
56c6f09 
…oj#21361)

Signed-off-by: Keith Chong <[email protected]>
@keithchong keithchong linked a pull request Jan 3, 2025 that will close this issue
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithchong keithchong

Labels
bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Update ui test to fix logic for headless mode, add logs (#21361) keithchong/argo-cd
1 participant
@keithchong