[Feature] Provide option to support auto-generate doc id by ES for insert trace record when use elasticsearch storage #12658
Unanswered
samz-github
asked this question in
Q&A
Replies: 2 comments
-
This is intentional. We controlled the ID to make sure it would be updated by doc ID, rather than query condition. This improves the performance. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Updated scene can be found in MetricsESDao class. For trace record doc, we just insert and query, and no update, right? If we mostly use trace record and seldom use metric, it's good to have a option to disable custom doc id? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Search before asking
Description
My corporation elasticsearch DBA feedback to me that skywalking use custom doc id butnot auto-generated by ES cluster, and it makes ES performace not good.
I have checked storage-eleasticsearch-plugin source code. Skywalking OAP query ES with the doc id for UI template. For query trace record, not using doc id, but other ES field, like segment_id or trace_id. Can we not to generate custom doc id when insert trace recod in ES? Instead, it just let ES auto generate doc id when inserting trace record.
`
`
Use case
It helps to improve ES performace when insert and search ES trace records, especially for huge trace records everyday .
Related issues
No response
Are you willing to submit a pull request to implement this on your own?
Code of Conduct
Beta Was this translation helpful? Give feedback.
All reactions