-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQLStatementParserCacheHook
to Provide Extension Point for Application SQL Parse Cache Warm-up , Referred to as Preheat
#34156
base: master
Are you sure you want to change the base?
Conversation
…ation SQL Parse Cache Warm-up , Referred to as Preheat
…ation SQL Parse Cache Warm-up , Referred to as Preheat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SQL always changes, using SPI to provide a static java class maybe not good enough.
As described in #34155 Objective: Facilitate application-level SQL parse cache warm-up to improve performance on initial queries. |
I do not hope SQL input to be through Java's SPI. ShardingSphere is a database (or database protocol), and all SQL-related content should be provided through standard JDBC. |
Thank you for the review. collect like:
warmup like:
|
Add
SQLStatementParserCacheHook
to Provide Extension Point for Application SQL Parse Cache Warm-up , Referred to as PreheatFixes #34155.
Changes proposed in this pull request:
SQLStatementParserCacheHook
to Provide Extension Point for Application SQL Parse Cache Warm-up , Referred to as PreheatBefore committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.