[improve][broker] Improve the extensibility of the TopicBundleAssignmentStrategy interface class (#23773) #23774
+185
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entStrategy interface class (apache#23773)
lhotari
reviewed
Jan 3, 2025
| @@ -23,5 +23,7 @@ | |||
| public interface TopicBundleAssignmentStrategy { | |||
| NamespaceBundle findBundle(TopicName topicName, NamespaceBundles namespaceBundles); | |||
|
|
|||
| long getHashCode(String name); | |||
There was a problem hiding this comment.
It's better to make the name of this method more specific. It's better to use the type TopicName as well and provide a default implementation. Please also add javadoc with proper description of the method.
Suggested change
| long getHashCode(String name); | |
| default long calculateBundleHashCode(TopicName topicName) { | |
| return Hashing.crc32().hashString(topicName.toString(), StandardCharsets.UTF_8).padToLong(); | |
| } |
| if (topicName.getDomain().equals(TopicDomain.non_persistent)) { | ||
| bundle.setHasNonPersistentTopic(true); | ||
| } | ||
| return bundle; | ||
| } | ||
|
|
||
| @Override | ||
| public long getHashCode(String name) { | ||
| return pulsar.getNamespaceService().getNamespaceBundleFactory().getHashFunc() |
There was a problem hiding this comment.
this doesn't look great since it's a "train wreck" anti-pattern to have long call chains to reach out to a dependency. could the hash function be passed in the constructor instead?
315157973
reviewed
Jan 3, 2025
| @Override | ||
| public void init(PulsarService pulsarService) { | ||
| this.pulsar = pulsarService; |
There was a problem hiding this comment.
We can hold a reference to HashFunc here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[improve][broker] Improve the extensibility of the TopicBundleAssignmentStrategy interface class (#23773)
Fixes #23773
PIP: #19806
Motivation
For details, see the description of issue #23773
Modifications
The implementation of the
NamespaceBundleFactory#getLongHashCodemethod is moved to the implementation class of the interfaceTopicBundleAssignmentStrategy. Therefore, a new methodlong getHashCode(String name)is added to theTopicBundleAssignmentStrategyinterface class. The implementation of the hash algorithm is no longer fixed in theNamespaceBundleFactory#getLongHashCodemethod. Instead, thegetHashCodemethod implemented by different algorithms is invoked.Verifying this change
This change is already covered by existing tests, such as TopicBundleAssignmentStrategyTest#testStrategyFactory, and added tests and can be verified as follows:
TopicBundleAssignmentStrategyTest
RoundRobinBundleAssigneris customized and theTopicBundleAssignmentStrategyinterface is implemented. Only the interfaces inTopicBundleAssignmentStrategyneed to be implemented. It's not needed to modify the interface implementation of other classes. The open and closed principles are met.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: