You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously with the version 5.4.3, we can import internal types, such as ValueAxisBaseOption, DataZoomOption, AreaStyleOption and so on, from files where they are defined.
These types are useful when we write unit tests or when we write util functions that customise these options based on certain parameters.
However since 5.6.0 we can no longer do this, because you updated the exports field in package.json and those files are no longer recognisable by typescript.
This might not be a bug, but it does break our type check. As a workaround, I added a patch to export them from /node_modules/echarts/types/dist/echarts.d.ts, so I can import in this way:
import{ValueAxisBaseOption}from'echarts'
I wonder if you can export them by default, so we get more precise types?
Please note that the moduleResolution in our tsconfig is set to bundler. Those types can still be imported if it's set to node. But in our case, we have to use bundler.
The text was updated successfully, but these errors were encountered:
Version
5.6.0
Link to Minimal Reproduction
https://codesandbox.io/p/sandbox/v29fdw
Steps to Reproduce
Previously with the version 5.4.3, we can import internal types, such as
ValueAxisBaseOption
,DataZoomOption
,AreaStyleOption
and so on, from files where they are defined.These types are useful when we write unit tests or when we write util functions that customise these options based on certain parameters.
However since 5.6.0 we can no longer do this, because you updated the
exports
field inpackage.json
and those files are no longer recognisable by typescript.This might not be a bug, but it does break our type check. As a workaround, I added a patch to export them from
/node_modules/echarts/types/dist/echarts.d.ts
, so I can import in this way:I wonder if you can export them by default, so we get more precise types?
Expected Behavior
Be able to import them
Environment
Any additional comments?
Please note that the
moduleResolution
in ourtsconfig
is set tobundler
. Those types can still be imported if it's set tonode
. But in our case, we have to usebundler
.The text was updated successfully, but these errors were encountered: