[Bug]: Gauge metrics are not extracted in metrics result. #33448
Comments
|
Hey @rohitsinha54 i am working on a fix for this issue . i will add a conditional Block to handle gauge metrics . could u please assign this issue to me ? |
|
I believe you can assignee the issue to yourself by comment |
kavyakapoor420
added a commit
to kavyakapoor420/AacheBugFix
that referenced
this issue
Jan 3, 2025
…esult This commit adds the necessary logic in the `addMetricResult` method to properly handle and extract gauge metrics from the committed and attempted updates. Previously, gauge metrics were missing from the metrics result, which prevented customers from querying them programmatically in Dataflow jobs. The fix includes: - Adding a conditional block to check for `getGauge()` in the MetricUpdate. - Ensuring that gauge metrics are added to the `gaugeResults` collection. This change should resolve issue apache#33448.
kavyakapoor420
added a commit
to kavyakapoor420/AacheBugFix
that referenced
this issue
Jan 3, 2025
This change should resolve issue apache#33448.
|
.take-issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
Specifically they are missing from addMetricResult here
beam/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowMetrics.java
Line 150 in 7930a1f
This would mean that customer cannot query back gauge metrics in their job programatically.
Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components
The text was updated successfully, but these errors were encountered: