GH-89: Add support for generating Flight related files #114
Conversation
| //go:generate protoc --experimental_allow_proto3_optional -I../../../format --go_out=./gen/flight --go-grpc_out=./gen/flight --go_opt=paths=source_relative --go-grpc_opt=paths=source_relative Flight.proto | ||
| //go:generate protoc --experimental_allow_proto3_optional -I../../../format --go_out=./gen/flight --go-grpc_out=./gen/flight --go_opt=paths=source_relative --go-grpc_opt=paths=source_relative FlightSql.proto | ||
| //go:generate protoc --experimental_allow_proto3_optional -I${APACHE_ARROW_FORMAT_DIR} --go_out=./gen/flight --go-grpc_out=./gen/flight --go_opt=paths=source_relative --go-grpc_opt=paths=source_relative Flight.proto | ||
| //go:generate protoc --experimental_allow_proto3_optional -I${APACHE_ARROW_FORMAT_DIR} --go_out=./gen/flight --go-grpc_out=./gen/flight --go_opt=paths=source_relative --go-grpc_opt=paths=source_relative FlightSql.proto |
There was a problem hiding this comment.
Can we move these protoc ... command lines to dev/sync_flight.sh and remove this file?
There was a problem hiding this comment.
the standard way of handling things like this would be to utilize go generate to run the commands rather than a separate sync script (ideally). So I'd personally prefer keeping this file and the go:generate lines.
There was a problem hiding this comment.
that said, it might be better to utilize buf instead see the links below on the substrait-go repo for how I did it there to reference and generate the protobuf from the .proto files in the substrait-io/substrait repo
https://github.com/substrait-io/substrait-go/blob/main/doc.go#L9
https://github.com/substrait-io/substrait-go/blob/main/buf.gen.yaml
There was a problem hiding this comment.
OK. I withdraw this approach.
|
We should use buf. |
Fix GH-89