Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How come this package is named react-*? #133

Open
nikitaeverywhere opened this issue Jun 4, 2024 · 3 comments
Open

How come this package is named react-*? #133

nikitaeverywhere opened this issue Jun 4, 2024 · 3 comments

Comments

@nikitaeverywhere
Copy link

nikitaeverywhere commented Jun 4, 2024

I quickly scanned through README.md and the code of the package, and I see literally nothing that means React or makes it usable with React only.

Why then it carries such a name?

CC @sooro-io @daniel-bartylla you might want to rename your package too, would you?

@daniel-bartylla
Copy link

I can't tell you why the package was originally named that way. But I agree with you, it is currently more of a generic utility function which is not actually React specific.

Regarding the renaming of the package. Since the next features to come will definitely be based on React elements, or even require them (contexts, hooks), I would leave the name react-*. This means that the package will develop in a significantly different direction than the original one. But at least it will live up to its name.

@encryptblockr
Copy link

is this package still working fine? last update is 4 years ago
does this still work with latest google tag manager?
ok to use in react production code??? @daniel-bartylla @nikitaeverywhere

@jaxzon
Copy link

jaxzon commented Dec 11, 2024

We use it in production for non-react project. 1 million active users on the sites combined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants