Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review security risks #30

Open
albireox opened this issue Feb 3, 2024 · 0 comments
Open

Review security risks #30

albireox opened this issue Feb 3, 2024 · 0 comments

Comments

@albireox
Copy link
Owner

albireox commented Feb 3, 2024

We are currently forcing code signing in PRs by forcing CSC_FOR_PULL_REQUEST: true in the publish.yml workflow. This raises the warning

There are serious security concerns with CSC_FOR_PULL_REQUEST=true (see the  CircleCI documentation (https://circleci.com/docs/1.0/fork-pr-builds/) for details)

Additionally I disabled Yarn's hardened mode with YARN_ENABLE_HARDENED_MODE: 0 which warns


➤ YN0000: Yarn detected that the current workflow is executed from a public pull request. For safety the hardened mode has been enabled.
➤ YN0000: It will prevent malicious lockfile manipulations, in exchange for a slower install time. You can opt-out if necessary; check our documentation for more details.

We should evaluate what's the actual risk here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant