You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's extremely puzzling, and frustrating, that this functionality isn't built-in to GitHub; perhaps we can use Monorobot to backfill.
Details
When someone assigns a team such as @org/fe as 'review requested' to some PR #1235, every single person in that team gets a GitHub notification added to their queue.
When a single one of those team-members @rver clicks that notification and reviews that PR (approved / changes-requested), GitHub is aware that the review is actually 'on behalf of' the team @org/fe:
Unfortunately, that knowledge doesn't seem to propagate to any meaningful effect. In particular, there's currently no way to set a 'maximum needed reviews' per team; even though @rver may have reviewed the parts of the PR that are relevant to your team, the additional notifications sent to the other 15 team members continue to clog up their inbox — even though there's now no action needed from any of them, they have to "click through" and check that, yes, somebody from their team has indeed ack'd the PRs they have notifications for.
Proposal
I'd like to see Monorobot process each review added to a PR, and resolve the above situation in some way.
Depending on what information is available via GitHub's API,
Ideally, specifically identify "in behalf of" reviews,
or if that's impossible, simply check if the reviewing person @rver is a member of any GitHub teams that have been requested-to-review, such as @org/fe;
and then remove the review-request referencing the whole team (thus clearing the notification/noise for other team-members.)
The text was updated successfully, but these errors were encountered:
It's extremely puzzling, and frustrating, that this functionality isn't built-in to GitHub; perhaps we can use Monorobot to backfill.
Details
When someone assigns a team such as
@org/fe
as 'review requested' to some PR#1235
, every single person in that team gets a GitHub notification added to their queue.When a single one of those team-members
@rver
clicks that notification and reviews that PR (approved / changes-requested), GitHub is aware that the review is actually 'on behalf of' the team@org/fe
:Unfortunately, that knowledge doesn't seem to propagate to any meaningful effect. In particular, there's currently no way to set a 'maximum needed reviews' per team; even though
@rver
may have reviewed the parts of the PR that are relevant to your team, the additional notifications sent to the other 15 team members continue to clog up their inbox — even though there's now no action needed from any of them, they have to "click through" and check that, yes, somebody from their team has indeed ack'd the PRs they have notifications for.Proposal
I'd like to see Monorobot process each review added to a PR, and resolve the above situation in some way.
@rver
is a member of any GitHub teams that have been requested-to-review, such as@org/fe
;The text was updated successfully, but these errors were encountered: