Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full width swipe back #101

Open
SpenHub opened this issue Jun 30, 2023 · 12 comments
Open

Full width swipe back #101

SpenHub opened this issue Jun 30, 2023 · 12 comments

Comments

@SpenHub
Copy link

SpenHub commented Jun 30, 2023

Hey loving the web app, it’s fantastic! One of my favorite features of Apollo is the ability to disable per-post gestures where instead a thumb swipe from left to right (anywhere on the page) will slide your current view/ pane off to the right, essentially acting as a back button.

@aeharding
Copy link
Owner

Huh! This would be cool.

Page gestures are fully controlled by Ionic, so this would be a question of what the library supports.

@SpenHub
Copy link
Author

SpenHub commented Jun 30, 2023

@aeharding I believe this can be implemented with Swiper. I would've recommended Ionic's ion-slide but it was deprecated in favor of Swiper.js. I'm just an SDET with limited DOM experience but it looks like one could wrap your subscribed list, post page, and comment page in this framework and that might enable such a feature.

GIF from their website dictating a possible look: 2023-06-30 16 31 29

https://swiperjs.com/get-started

@ctmay4
Copy link

ctmay4 commented Jul 1, 2023

I noticed this as well. I seem to remember in Apollo that most anywhere on the page would swipe back or forwards but the edges could still swipe to collapse comments, etc. Would be a great improvement. I sometimes forget I'm not using Apollo!

@JonoHall
Copy link

JonoHall commented Jul 1, 2023

One of the first features I miss when I switched. Thank you for submitting this!

It's also a gesture that has become native to me on all apps. For example, I try to full swipe on GitHub, I go into an issue and try to swipe back to the index!

@SpenHub
Copy link
Author

SpenHub commented Jul 1, 2023

@JonoHall I'm gonna try to get WSL working today and see if I can work up a POC to submit to aeharding, wish me luck!

Also have plans to implement:

  1. Thumbnails on right side in compact mode
  2. Hide voting buttons (in favor of kebab menu)
  3. Mark as read on media-view

@aeharding
Copy link
Owner

Created ionic-team/ionic-framework#27743 to track this library-side

@robertafreese
Copy link

I think this is possible using configurable gestures, which is #64 - this is how I had Apollo set up. I disabled both left and right swipes and left Disable navigation gestures off aka enabled navigation gestures.

@gobbledygoober
Copy link

Is this resolved in 1.9.1 with #662 ?

@SpenHub
Copy link
Author

SpenHub commented Aug 15, 2023

Is this resolved in 1.9.1 with #662 ?

@gobbledygoober unfortunately not

@aeharding
Copy link
Owner

I did some research and it can technically be implemented right now - however there will be the limitation that no swipeable items will work (not even swipe right). So I could implement that if people would find it useful. Otherwise we have to wait for ionic-team/ionic-framework#27743

@SpenHub
Copy link
Author

SpenHub commented Aug 15, 2023

@aeharding I am personally a-ok with that compromise given that's how Apollo functioned iirc. If you need some inspiration, two other lemmy apps that have full-width swipe back are Memmy & Liftoff (liftoff is a PWA too)

Additionally if you need a beta-beta tester lmk, I'm an SDET/ QA by trade <3

@battaglia01
Copy link

I did some research and it can technically be implemented right now - however there will be the limitation that no swipeable items will work (not even swipe right). So I could implement that if people would find it useful. Otherwise we have to wait for ionic-team/ionic-framework#27743

I will just add that I also would be happy with this. Or perhaps if you could make it so there's a slider denoting how far toward the edge of the screen the "valid swipe back" region is. I had no idea that swipe to go back was even implemented before reading this! It's great, it's just that the gesture in its current form requires the beginning of the swipe to be too far toward the edge of the left screen. I would be happy if it were the entire screen without any left-swipe gestures on comments and etc, FWIW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants