-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full width swipe back #101
Comments
Huh! This would be cool. Page gestures are fully controlled by Ionic, so this would be a question of what the library supports. |
@aeharding I believe this can be implemented with Swiper. I would've recommended Ionic's |
I noticed this as well. I seem to remember in Apollo that most anywhere on the page would swipe back or forwards but the edges could still swipe to collapse comments, etc. Would be a great improvement. I sometimes forget I'm not using Apollo! |
One of the first features I miss when I switched. Thank you for submitting this! It's also a gesture that has become native to me on all apps. For example, I try to full swipe on GitHub, I go into an issue and try to swipe back to the index! |
@JonoHall I'm gonna try to get WSL working today and see if I can work up a POC to submit to aeharding, wish me luck! Also have plans to implement:
|
Created ionic-team/ionic-framework#27743 to track this library-side |
I think this is possible using configurable gestures, which is #64 - this is how I had Apollo set up. I disabled both left and right swipes and left Disable navigation gestures off aka enabled navigation gestures. |
Is this resolved in 1.9.1 with #662 ? |
@gobbledygoober unfortunately not |
I did some research and it can technically be implemented right now - however there will be the limitation that no swipeable items will work (not even swipe right). So I could implement that if people would find it useful. Otherwise we have to wait for ionic-team/ionic-framework#27743 |
@aeharding I am personally a-ok with that compromise given that's how Apollo functioned iirc. If you need some inspiration, two other lemmy apps that have full-width swipe back are Memmy & Liftoff (liftoff is a PWA too) Additionally if you need a beta-beta tester lmk, I'm an SDET/ QA by trade <3 |
I will just add that I also would be happy with this. Or perhaps if you could make it so there's a slider denoting how far toward the edge of the screen the "valid swipe back" region is. I had no idea that swipe to go back was even implemented before reading this! It's great, it's just that the gesture in its current form requires the beginning of the swipe to be too far toward the edge of the left screen. I would be happy if it were the entire screen without any left-swipe gestures on comments and etc, FWIW. |
Hey loving the web app, it’s fantastic! One of my favorite features of Apollo is the ability to disable per-post gestures where instead a thumb swipe from left to right (anywhere on the page) will slide your current view/ pane off to the right, essentially acting as a back button.
The text was updated successfully, but these errors were encountered: