Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popover] considerations when migrating to popover API #1837

Open
Westbrook opened this issue May 3, 2023 · 0 comments
Open

[Popover] considerations when migrating to popover API #1837

Westbrook opened this issue May 3, 2023 · 0 comments
Assignees
@pfulton @5t3ph
Labels
enhancement A request to add a feature to a component question Further information is requested research Flag for research needed or in progress sync to jira These will be pushed into adobe internal jira

Comments

@Westbrook
Copy link
Contributor

Westbrook commented May 3, 2023 •
edited
Loading

With the coming implementation of APIs like the popover attribute, it will be possible to have UIs that features Popovers and desendents of Popovers. In doing so, the filter found at:

spectrum-css/components/popover/index.css

Line 70 in cafd1a3

filter: drop-shadow(var(--mod-popover-shadow-horizontal, var(--spectrum-popover-shadow-horizontal)) var(--mod-popover-shadow-vertical, var(--spectrum-popover-shadow-vertical)) var(--mod-popover-shadow-blur, var(--spectrum-popover-shadow-blur)) var(--mod-popover-shadow-color, var(--spectrum-popover-shadow-color)));
will stack as seen here: https://codepen.io/Westbrook/pen/BaqmJjP with the .spectrum-Popover element with the red drop shadow filter. We need something like what is seen in .spectrum-Popover--alt so that subsequent filters can be removed so that they do not stack.

image
@pfulton pfulton added the sync to jira These will be pushed into adobe internal jira label May 4, 2023
@mlogsdon18 mlogsdon18 mentioned this issue May 30, 2023
Merged
7 tasks
@castastrophe castastrophe changed the title Styling Popover when leverage popover. [Popover ] Styling Popover when leverage popover Dec 10, 2024
@castastrophe castastrophe added question Further information is requested research Flag for research needed or in progress enhancement A request to add a feature to a component labels Dec 10, 2024
@castastrophe castastrophe changed the title [Popover ] Styling Popover when leverage popover [Popover] considerations when migrating to popover API Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfulton pfulton

@5t3ph 5t3ph

Labels
enhancement A request to add a feature to a component question Further information is requested research Flag for research needed or in progress sync to jira These will be pushed into adobe internal jira
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pfulton @Westbrook @castastrophe @5t3ph