Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--k3s-arg=--disable=... does nothing but --kubernetes-disable still works #1222

Open
1 of 5 tasks
sdemura opened this issue Dec 17, 2024 · 3 comments
Open
1 of 5 tasks

Comments

@sdemura
Copy link

sdemura commented Dec 17, 2024

Description

Starting colima with custom --k3s-arg doesn't work.

Using colima start --help example:

colima start --kubernetes --k3s-arg=--disable=coredns,servicelb,traefik,local-storage,metrics-server

colima installs traefik, servicelb, local-path-provisioner (local-storage), metrics-server but does NOT install coredns.

k9s screenshot
image

Looking at the source, it looks like --kubernetes-disable is still available but hidden. If I use that version, then colima does the right thing

ex:

colima start --kubernetes --kubernetes-disable=coredns --kubernetes-disable=servicelb --kubernetes-disable=traefik --kubernetes-disa
ble=local-storage --kubernetes-disable=metrics-server

k9s screenshot
image

Version

❯ colima version && limactl --version 
colima version 0.8.1
git commit: 96598cc5b64e5e9e1e64891642b91edc8ac49d16
limactl version 1.0.2

Operating System

  • macOS Intel <= 13 (Ventura)
  • macOS Intel >= 14 (Sonoma)
  • Apple Silicon <= 13 (Ventura)
  • Apple Silicon >= 14 (Sonoma)
  • Linux

Output of colima status

No response

Reproduction Steps

Expected behaviour

colima start --kubernetes --k3s-arg=--disable=coredns,servicelb,traefik,local-storage,metrics-server should actually disable the specified components.

Additional context

No response

@abiosoft
Copy link
Owner

Thanks for reporting, definitely a bug.

@abiosoft abiosoft added the bug Something isn't working label Dec 18, 2024
@olamilekan000
Copy link
Contributor

This isn't actually really a bug. The issue is with your command. it should be like this since the k3s-arg flag expects multiple strings as values.

colima start --kubernetes --k3s-arg="--disable=coredns,servicelb,traefik,local-storage,metrics-server"

or

Screenshot 2024-12-27 at 01 54 55

Screenshot 2024-12-27 at 01 50 20

Here is my k8s cluster after running it with this command.
Screenshot 2024-12-27 at 01 53 51

@sdemura @abiosoft

@abiosoft abiosoft removed the bug Something isn't working label Jan 1, 2025
@abiosoft
Copy link
Owner

abiosoft commented Jan 1, 2025

It is not a bug. The argument needs to be quoted and it should work as desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants