Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak Auras still show up for update after being removed #2680

Open
1 of 3 tasks
sleepgoing opened this issue Dec 10, 2024 · 1 comment
Open
1 of 3 tasks

Weak Auras still show up for update after being removed #2680

sleepgoing opened this issue Dec 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@sleepgoing
Copy link

sleepgoing commented Dec 10, 2024

Operating System:

  • Windows
  • Mac
  • Linux

Companion Version:
5.2.7
Check the bottom left of the "About" panel in the app.


**Companion App Console Log:**
index-CA-za9nQ.js:32 userDataPath C:\Users\sleep\AppData\Roaming\weakauras-companion
index-CA-za9nQ.js:51 validateWowPath
index-CA-za9nQ.js:51 buildVersionList
2index-CA-za9nQ.js:22 buildAccountList
index-CA-za9nQ.js:31 {}
index-CA-za9nQ.js:113 Creating default directory
index-CA-za9nQ.js:31 promisesWagoCallsComplete
index-CA-za9nQ.js:31 promisesWagoDataCallsComplete
index-CA-za9nQ.js:54 writeAddonData
index-CA-za9nQ.js:74 WeakAuras.toc has version: 110005
index-CA-za9nQ.js:31 Error testing Plater SV access
{"errno":-4058,"code":"ENOENT","syscall":"access","path":"H:\\World of Warcraft\\_retail_\\WTF\\Account\\1104949169#1\\SavedVariables\\Plater.lua"}
index-CA-za9nQ.js:31 Error testing WeakAuras SV access
{"errno":-4058,"code":"ENOENT","syscall":"access","path":"H:\\World of Warcraft\\_retail_\\WTF\\Account\\1125441952#1\\SavedVariables\\WeakAuras.lua"}
index-CA-za9nQ.js:31 Error testing Plater SV access
{"errno":-4058,"code":"ENOENT","syscall":"access","path":"H:\\World of Warcraft\\_retail_\\WTF\\Account\\1125441952#1\\SavedVariables\\Plater.lua"}
index-CA-za9nQ.js:31 Error testing WeakAuras SV access
{"errno":-4058,"code":"ENOENT","syscall":"access","path":"H:\\World of Warcraft\\_retail_\\WTF\\Account\\308368836#1\\SavedVariables\\WeakAuras.lua"}
index-CA-za9nQ.js:31 Error testing Plater SV access
{"errno":-4058,"code":"ENOENT","syscall":"access","path":"H:\\World of Warcraft\\_retail_\\WTF\\Account\\308368836#1\\SavedVariables\\Plater.lua"}
index-CA-za9nQ.js:31 Error testing Plater SV access
{"errno":-4058,"code":"ENOENT","syscall":"access","path":"H:\\World of Warcraft\\_retail_\\WTF\\Account\\401609362#1\\SavedVariables\\Plater.lua"}
index-CA-za9nQ.js:31 Error testing Plater SV access
{"errno":-4058,"code":"ENOENT","syscall":"access","path":"H:\\World of Warcraft\\_retail_\\WTF\\Account\\494321703#1\\SavedVariables\\Plater.lua"}
index-CA-za9nQ.js:51 Backup: WeakAuras-_retail_#SLEEPGOING-20241210002153.zip saved
index-CA-za9nQ.js:51 Backup: Plater-_retail_#SLEEPGOING-20241210002153.zip saved
Press Ctrl+Shift+I to open the console and copy-paste everything here

WeakAuras Version:
5.18.0
/run print(WeakAuras.versionString) in-game.


**WeakAuras Errors:**

No errors in-game, the issue is that I remove the weakaura and they still show up for updates in the companion.

1. Install https://mods.curse.com/addons/wow/BugSack
2. Install https://mods.curse.com/addons/wow/bug-grabber
3. Try to do whatever it is you're having a problem with again
4. Check your minimap for an icon that looks like a bag.  Is it green, or is it red?
   • GREEN
      • WeakAuras is working correctly.
      • Either you found a behavioral bug, or you are just doing it wrong :)
      • Explain the steps you took, and we will try to figure out what happened.
   • RED 
     • There are error messages. Click on the red bag to see them.
     • Copy & Paste here all of the error messages (there may be more than one, click the 'previous' button on the dialog to see previous ones

Describe the bug
No errors in-game, the issue is that I remove the weakaura and they still show up for updates in the companion.

To Reproduce
Steps to reproduce the behavior:

  1. Install one of the "current raid Tier weak aura packs"
  2. Remove it
  3. Close and then re-launch the game
  4. Open the companion and refresh to search for updates

Expected behavior
The weak aura should no longer show up for updates

Screenshots
image

Include a .zip file containing:
%programfiles%\World of Warcraft\_retail_\WTF\Account\<AccountName>\SavedVariables\WeakAuras.lua
WeakAuras.txt

AND
%appdata%\weakauras-companion\config.json
config.json

@sleepgoing sleepgoing added the bug Something isn't working label Dec 10, 2024
@xAt0mZ
Copy link

xAt0mZ commented Jan 5, 2025

FWIW to update the list in game (and remove leftovers on both sides) you need to

  • close the WeakAura companion app
  • then reopen it
  • then reload the UI in game (or logout/restart the game)

Same desync happens when you install a WA. You need to close the app to have the Ready to install list of the WAC to be updated.
I'd expect the companion "Fetch updates" button to resync from the state of the game when its clicked without having to close/reopen the app.

The flow is / should be

  • send WA to WAC from Wago

  • WA appears in the bottom bar of WAC as Ready to install (1)
    image

  • in game, reload the UI, the WA will appear in the Ready for install list
    image

  • install the WA

  • reload UI (has to be done to persist the saved vars to disk)

  • WA still appears in the Ready for install list in game (expected as WAC didn't refresh its internal state)

  • in WAC click Fetch Updates

    • is: WA still shown as Ready to install (1) ; need to close and reopen WAC to pick up the changes
    • should be: On Fetch Updates click, WAC should reload the WA list as it does on startup
  • remove WA & reload UI (to persist the changes)

  • in WAC click Fetch Updates

    • is & should be : WAC doesn't show WA in the list when the WA was up to date
    • is: WAS still list WA when WA wasn't up to date
    • should be: WAC doesn't list the WA anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants