Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile legacy branch #17

Open
halfninja opened this issue Apr 7, 2022 · 1 comment
Open

Reconcile legacy branch #17

halfninja opened this issue Apr 7, 2022 · 1 comment

Comments

@halfninja
Copy link
Member

This is mainly a reminder issue for myself to look at this when there's time.

In 2021 some changes were made on the main branch. This auto-published a new latest image to Docker Hub, but the changes were incompatible with the way that sso-stub is being used in Docker Compose stacks. For now the legacy branch exists starting from the last commit used to build a tagged version of the image that is currently working for our Compose stacks, and so further images will be built from that.

Review the changes made since then and try to find a middle ground so we can get back to one branch.
@halfninja
Copy link
Member Author

One issue is that ef5ce94 removed log4j - but OpenSAML refers to it and it crashes at runtime. Probably want to replace with slf4j-over-log4j.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@halfninja