Merge proprietary into open-source, June/July 2022 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axisofentropy
changed the title
zipofar
reviewed
Jun 30, 2022
Makefile
Outdated
|
|
||
| build_shell: | ||
| docker-compose build | ||
| docker compose build |
There was a problem hiding this comment.
I think docker-compose build was correct
zipofar
reviewed
Jun 30, 2022
Makefile
Outdated
|
|
||
| up: | ||
| docker-compose up | ||
| docker compose up |
There was a problem hiding this comment.
I think docker-compose up was correct
zipofar
reviewed
Jun 30, 2022
Makefile
Outdated
|
|
||
| shell: | ||
| docker-compose run --service-ports --rm controller bash | ||
| docker compose run --service-ports --rm controller bash |
There was a problem hiding this comment.
I think docker-compose run --service-ports --rm controller bash was correct
zipofar
reviewed
Jun 30, 2022
Makefile
Outdated
| @@ -23,16 +23,16 @@ NO_COLOR='\033[0m' | |||
| clean_world: destroy_shell build_shell up | |||
|
|
|||
| destroy_shell: | |||
| docker-compose down -v | |||
| docker compose down -v | |||
There was a problem hiding this comment.
I think docker-compose down -v was correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.