Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cmake config option to allow build video module with mit license retained. #121

Open
eebssk1 opened this issue Aug 26, 2024 · 1 comment

Comments

@eebssk1
Copy link

eebssk1 commented Aug 26, 2024

You can add a definition so video module will only look for bsd/lgpl licensed encoders like kvazaar/svt-av1/openh264.
Which make your video module lgpl. Thus keeps your project as mit since lgpl does not effect the whole code,only the one that modify the lgpl-ed code.

Also i think the video module can also be mit because it only effect code that modify lgpl code. It's clearly that you are just using it instead of modifying.

@TianZerL
Copy link
Owner

I cannot control witch pre-build ffmpeg libs user will use to build video module. And I simply pass the user specified encoder to ffmpeg.
I think GPL3 is the safest option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@eebssk1 @TianZerL and others