-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minified attributes seem to be double encoded #148
Comments
Hello, Tom! It seems to me that there should be a semicolon in the value of this attribute: <span class="button close" data-icon="" aria-hidden="true">…</span> |
I will try to fix this error during the next week. |
Hello, Tom! In the beginning, I thought that I could quickly fix this problem by simply editing one line of code, but it turned out to be much more complicated. System.Net.WebUtility.HtmlDecode method that I'm using to decode does not support HTML entities without a semicolon. Unfortunately, there is no ready-made analogue of the he library for .NET, so it will take quite a long time to implement such functionality. In general, usage of the HTML entities without a semicolon is a rather controversial thing (see the “Are there some valid HTML entities without the semicolon?” discussion on Stack Overflow). I can't exclude the At the moment I recommend that you manually add semicolons to the HTML entities. |
Hey Andrey, You've already pointed me in an excellent direction. I'll look into using the semicolon, which is fine if our code works with it, that's a fixable situation. |
When WebMarlupMin minifies something like this:
span class="button close" data-icon="" aria-hidden="true"
it comes out with the ampersand encoded like this:
span class="button close" data-icon="" aria-hidden="true"
(opening and closing html tag removed since github filters them out)
The text was updated successfully, but these errors were encountered: