Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-mobile optimizations: grids #126

Open
ujmappa opened this issue Oct 21, 2023 · 10 comments
Open

Pre-mobile optimizations: grids #126

ujmappa opened this issue Oct 21, 2023 · 10 comments
Labels
future v-next, THE FUTURE, MARTY! user interface

Comments

@ujmappa
Copy link

ujmappa commented Oct 21, 2023

While grids are great and I confirm that these work on mobile as well, they are pretty difficult to maintain in bootstrap, so as first step I suggest to remove them where possible covering two main parts:

  • Images should be displayed on cards, meaning that whereever they appear they should be tiles and no option to switch
  • Users could be displayed on cards as well (artists and users with some "order by" fields on the top)
  • History should be displayed in a more elegant way on a timeline. You can find an example here with pure css: https://bbbootstrap.com/snippets/user-business-timeline-32289439

If there is any other usage of grids, please let me know, I identified these three.

@Mike-E-angelo
Copy link
Member

When you say grids you mean bootstrap grids of the 12-divisions kind? If so I additionally complicated it up front with another control toolkit that uses its own flavor, and used that for a while, thinking it was a better solution, when in fact it was not necessary at all. 😬

@ujmappa
Copy link
Author

ujmappa commented Oct 21, 2023

When you say grids you mean bootstrap grids of the 12-divisions kind? If so I additionally complicated it up front with another control toolkit that uses its own flavor, and used that for a while, thinking it was a better solution, when in fact it was not necessary at all. 😬

I mean that non-tile mode in case of inventory, user list, etc. With the client-side filters...

@Mike-E-angelo
Copy link
Member

Ah those are Syncfusion grids and most of the work managing is already taken care of ATM :)

There is a lot of functionality in there, replacing them would be non-trivial as we'd have to take the built-in LINQ-parsing/filtering and essentially create/manage it custom code.

@Mike-E-angelo Mike-E-angelo added future v-next, THE FUTURE, MARTY! user interface labels Oct 21, 2023
@ujmappa
Copy link
Author

ujmappa commented Oct 21, 2023

Ah those are Syncfusion grids and most of the work managing is already taken care of ATM :)

There is a lot of functionality in there, replacing them would be non-trivial as we'd have to take the built-in LINQ-parsing/filtering and essentially create/manage it custom code.

Mmm. In case of images replacement of it would take literally nothing, just removing one switch.
In case of users the same tile handling should be added like in inventory items, so it should not be a big deal.
In case of history it's a bigger change, but basically it would be fetching all the same data and show it in some other view.

You see, maintaining that view in bootstrap for mobile is a big deal, a lot bigger than to replace them with simple bootstrap controls. Point one and two are a few hours of jobs. Point three is not that big of a deal on the server side.. More in the generated HTML, but after one is done (maybe one day of a job), it's pretty straightforward.

@ujmappa
Copy link
Author

ujmappa commented Oct 21, 2023

But now you also made me curious about that "another control toolkit". Where can I find that? Because it should be removed :D

@Mike-E-angelo
Copy link
Member

Those tasks are simple but how are we going to preserve filtering/sorting which is very good along with a built-in Excel-type filter control which I find very powerful/handy :)

@Mike-E-angelo
Copy link
Member

Because it should be removed :D

Nodding along and if it were easy like that I would have done it long ago. But you cannot simply remove you have to replace which means preserving existing functionality and that nothing is broken in both desktop + mobile. There are platform considerations as well between browsers.

ATM it is "if it ain't broken don't fix it" until we have the monies to do a full sweep v2 (future).

But to answer your question we are using Radzen, MatBlazor, and Syncfusion.

I'd rather remove everything but Syncfusion who support their product incredibly well.

@Mike-E-angelo
Copy link
Member

Also I am not sure what you mean by manage bootstrap grids being a big deal I spend very little time w/ Bootstrap and in fact it's one of the easier parts about the UX :)

@ujmappa
Copy link
Author

ujmappa commented Oct 21, 2023

Those tasks are simple but how are we going to preserve filtering/sorting which is very good along with a built-in Excel-type filter control which I find very powerful/handy :)

You do not need them for history and users. You might need them for the inventory and definitions filtering status (and maybe a quick search for the titles).

@ujmappa
Copy link
Author

ujmappa commented Oct 21, 2023

Also I am not sure what you mean by manage bootstrap grids being a big deal I spend very little time w/ Bootstrap and in fact it's one of the easier parts about the UX :)

I'm sorry, maybe there is a missunderstanding here. I don't want them to be replaced by bootstrap grids. My proposal was to replace them with tiles and history with bootstrap timeline. No bootstrap grids were involved, those are tricky bastards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future v-next, THE FUTURE, MARTY! user interface
Projects
None yet
Development

No branches or pull requests

2 participants