-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tank modifier draws excessive fluid while interacting with fluid tanks in other mods #5257
Comments
Yeah, I need more context on this one. The tools work perfectly fine with our tanks, and its the tank that implements interaction behavior on right click. Do you also have this issue with seared tanks right clicking on the other mod's fluid tank? Also try with copper cans. |
No, seared/scorched tank and copper cans works just fine, the issue seemed to only happen with modifiable items. |
Does this issue happen on 1.18? Does it happen with any mods other than Melanism? E.g. create or immersive engineering |
Now I've tested tanks from create , immersive engineering , pneumaticcraft , functional storage and also tested transfering fluid from AE2 terminal, and the issue didn't occur.It only happens with tanks in mekanism and industrial foregoing. Also this issue does happens on 1.18 (with tcon ver. 3.6.4.113). |
Okay, if the issue also existed on 1.18 that rules out the recent refactors as causing this. I am going to bet since it only happens with a small subset of mods that the issue is actually on Mekanism and Industrial Foregoing's sides, they are likely not doing enough safety checks for fluid transfer. I recommend crossposting the issue there and linking it here. If I am doing something wrong on my side, somehow it works in basically every other mod. For some additional context for the crosspost, Tinker tools with tanks support variable amounts of fluid with a fixed max capacity, though that max capacity is determined by NBT. The tools also don't always have a tank, some NBT variants will be listed as having 0 tanks. |
Just a reminder that this issue needs a cross post if you want it resolved. Tommy knowledge there is nothing I can do on my side to fix it |
I see , but mekanism had already stopped supporting 1.19 and close the section of sending 1.19 issue long ago.So i guess this can't be solved anymore. |
This problem still exisits in 1.20 ,so I guess i can try creating 1.20 issue? (Though mekanism lables that 1.20 verson is no longer being developed) |
Sure, key this is Mekanism knows there is something wrong and can either fix it for their future builds or explain the problem on our side. |
Crosspost was added to Mekanism: mekanism/Mekanism#8312 |
Minecraft Version
1.19.2
Forge Version
43.4.0
Mantle Version
1.10.36
Tinkers' Construct Version
3.8.3.39
Describe your issue
When interacting with fluid tanks in Mekanism mod using tools with tank modifier, the fluid will be totally drained EVEN IF the tank holds more fluid than fluid capacity of the tool. Same situation also happens with fluid tanks in Industrial Foregoing.
2024-09-04.14-21-06.1.mp4
Crash Report
No response
Other mods
Mekanism -10.3.9
Just Enough Items -11.6.0.1019
TConJEI -1.2.1
Tried reproducing with just Tinkers?
No
Performance Enchancers
None of the above
Searched for known issues?
Searched open issues, Searched closed issues, Checked the FAQ, Checked the in game books
The text was updated successfully, but these errors were encountered: